Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui/language_selection: Rephrase text about becoming a translator #8905

Merged

Conversation

stevecotton
Copy link
Contributor

The link with details about individual compaigns is useful to players, even if they aren't looking to become translators. So move it upwards.

The text about first-time players seemed confusing to me, as the choice is already limited to languages that the player can read. Rearrange it to say that people should be familiar with most of the campaigns before considering joining the translation teams.

The current text was added in #8792, and backported to 1.18 after 1.18.0, so this changes text which hasn't yet entered the .pot files. The first paragraph is unchanged - I'm wondering if it should start with "The".

image

@stevecotton stevecotton added Enhancement Issues that are requests for new features or changes to existing ones. Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Translations Issues with translations, translation tooling, the translations engine, or code that uses it. UI User interface issues, including both back-end and front-end issues. labels May 22, 2024
@Wedge009
Copy link
Member

I agree 'The Battle for Wesnoth' is the full title.

I think 'decorated link' is fine, but I suppose translators accustomed to en_US may find the changed text easier to understand.

" +
# po: Beneath the label widget displaying this text there is a widget displaying
# po: a clickable link to <https://gettext.wesnoth.org/> (which opens in the user’s browser).
_ "<b>Note:</b> The translation percentages shown apply to the core game interface and in-game help only. More complete stats, including details for each campaign, are available at the following page."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this should end in : as before.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My feeling is that the two links should be consistent, so if one ends with a colon, they both ought to. OTOH, it looks like the other one needs reworking anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it's also mildly confusing to call the link a page. Maybe webpage would be a bit clearer though I'd use link as suggested below.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think either work - it seems perfectly reasonable that someone sees "page", sees the link, and understands that "page" refers to the web page at that link.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, and I think you can replace page with lots of other words and people can figure it out as well. When I read page I needed the figure out step. In my case if the word link is used I don't need the figure out step. Might be different for other people of course.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-added the colons, but left it with "page".

@stevecotton
Copy link
Contributor Author

stevecotton commented May 24, 2024 via email

@Pentarctagon
Copy link
Member

What information do we expect them to make that decision on? For example, adding "because campaign text may refer to units by unit type" would be a reason, although given the likely split between core and campaign translation, it might be a reason to choose the option with the lower percentage of core translated.

I think the sentence is mostly just redundant. If a language they can read is listed, then they'll pick that one. If there are multiple listed, then they'll pick the one with the higher percentage completed. You don't need to tell people that explicitly.

The link with details about individual compaigns is useful to players,
even if they aren't looking to become translators. So move it upwards.

The text about first-time players seemed confusing to me, as the choice
is already limited to languages that the player can read. Reworded it,
but after discussion in the PR, neither version was better than just
removing it.
@stevecotton
Copy link
Contributor Author

Given the comments, I feel emboldened to cut half of the first paragraph too. "The Battle for Wesnoth relies on volunteers for development, including translation. Translations may drift behind or even become abandoned."

image

@stevecotton stevecotton force-pushed the rephrase_language_window_master branch from e8e4fd3 to f276fe0 Compare May 25, 2024 07:57
@stevecotton stevecotton merged commit c2072f2 into wesnoth:master May 26, 2024
18 checks passed
@stevecotton stevecotton deleted the rephrase_language_window_master branch May 26, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Enhancement Issues that are requests for new features or changes to existing ones. Translations Issues with translations, translation tooling, the translations engine, or code that uses it. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants