Fix building with Xcode 10

[hrubymar10]

Problem description

Whole problem is described in issue #3350

TODO

• Rename problematic files - 49f6736
• Fix Visual Studio project - ac43a2d
• Fix CMake, Scons and CodeBlocks builds - ef7a24e
• Fix issue 1) Load screen missing - NOT CAUSED BY XCODE 10
• Fix issue 2) Blurry video in window mode - 5a89822
• Fix issue 3) Bad resolution in fullscreen - 5a89822

New bugs introduced by XCode 10

1) Blank screen on start

Game starts with blank screen. You can click elements (you can hear click sound) but you won't see anything until you move window. When you move window or resize it video appears. This issue is not caused by Xcode 10 but by macOS 10.14 api changes. I'll create new issue for tracking macOS 10.14 specific problems.

2) Blurry video in window mode

3) Bad resolution in fullscreen

When I switch game to fullscreen display starts to be cropped. Click coordinates works as expected (means that when you click somewhere in bottom right side, you will got window with credits or game quits or preferences appears (depends on where exactly you click)

(Before click)

(After click)

[hrubymar10]

Update
Issue 2) and 3) are probably caused by retina/Hi-DPi scalling on my MacBook Pro (with retina display)

Bonus
Wesnoth now supports darkmode on macOS 10.14 😄
what is totally important...

[Vultraz]

1 is almost certainly the same underlying window size issue as the other bugs. The logo and text draw, just outside the bounds of the visible area.

[hrubymar10]

Update
2) and 3) could be fixed by including window_flags |= SDL_WINDOW_ALLOW_HIGHDPI; into video.cpp

[Vultraz]

To be expected, yes.

[hrubymar10]

@Vultraz , can I include this flag to all builds (including windows, linux, ...) or only for apple? (#if defined(__APPLE__)).

Also another question: It is easy fix but isn't it just workaround?

[Vultraz]

That flag is indeed meant to be used on high-DPI systems, though I think it's really meant for macOS, since Windows doesn't use the macOS method of having a canvas 2x the size rendered in 1x the space. Should be fine on all builds.

[jyrkive]

This line should be indented with tabs.

[hrubymar10]

F**k... Again? 😃

[hrubymar10]

Fixed - 0021006

[hrubymar10]

Update
I just realised that issue 1) is little bit different. It starts with loadscreen but you can't see anything until you move window. Redraw order?

[hrubymar10]

Update
Cannot reproduce issue 1) when building on Xcode 10 using macOS 10.13 SDK. Problem is probably caused by change introduced with macOS 10.14 SDK.

IIRC there was some changes in 10.14 SDK around graphics. Apple deprecated OpenGL in favour of Metal. Maybe it is related.

From macOS 10.14 Beta 6 Release notes:

OpenGL and OpenCL Deprecation
Deprecations
• The APIs in the OpenGL and OpenCL frameworks are deprecated and remain present for compatibility purposes. Transition to Metal if your app is using OpenGL or OpenCL.

Xcode 10 Beta 5 Release Notes available from unofficial 3rd-party site: https://devapple.weebly.com/uploads/1/0/8/0/108009593/release_notes_for_xcode_10_beta_5.pdf

and

macOS 10.14 Beta 6 Release Notes available from unofficial 3rd-party site: https://www.scribd.com/document/385580441/MacOS-10-14-Beta-6-Release-Notes

[hrubymar10]

Ok, maybe we can merge this PR and create new issue for blank screen.

[hrubymar10]

I am on right track with issue number 1

This issue is NOT cause by Xcode 10 but by macOS 10.14 SDK. Please merge this PR as all problems with Xcode 10 are fixed and I'll open new issue for tracking macOS 10.14 specific issues.

[CelticMinstrel]

You should edit WIP out of the title once it's no longer the case.

[CelticMinstrel]

Needs to be done on master too now, right?