Make the fire terrains actually illuminate their hex #3457
Conversation
this would bring the whiteboard data of the differnt clients out of sync which could be a problem since the wb network protocoll identifies the actions to be removed ot replaced by index.
…mption
Fixes wmllint crashing like this upon encountering a gzip tarball in an
add-on:
Traceback (most recent call last):
File "/home/shadowm/bin/wmllint-1.14", line 3188, in <module>
for fn in allcfgfiles(directory):
File "/home/shadowm/bin/wmllint-1.14", line 2944, in allcfgfiles
if interesting(os.path.join(root, name)):
File "/home/shadowm/bin/wmllint-1.14", line 2927, in interesting
return fn.endswith(".cfg") or is_map(fn) or issave(fn)
File "/home/shadowm/src/wesnoth-1.14/data/tools/wesnoth/wmltools3.py", line 270, in issave
return firstline.startswith("label=")
TypeError: startswith first arg must be bytes or a tuple of bytes, not str
[ci skip]
This is a good point since it ensures any place that might use the title before the lobby (don't think there's any such places right now) won't inadvertently get formatted. Also might be worth looking into a way to just strip formatting completely.
This reverts commit 58a2e23.
…erver This avoids an issue where people could still apply formatting by using an older client. Granted, any formatting would still appear in-lobby to anyone using an older client, but this at least prevents the possibility of formatting appearing indefinitely if a game host happens to never update their own client.
Fixes issue #3286. [ci skip]
This likely existed because this code was added in 2014 before we switched to C++11 and initializer lists.
[ci skip]
Also dropped some unused code in unit_type. And there's still one in language.cpp, but I'm not entirely sure if it's safe to drop the last empty entry there so I left it.
There's really no reason to have this anymore. It was (AFAIK) introduced years ago as a performance-saving measure, then was moved to Advanced Preferences in 1.13 since modern PCs mostly have no issues. With accelerated rendering, there's even less of a reason to have this.
[ci skip] For some reason, this made the entire page stack thinner than it should be. I have no idea why, and I'm not sure wrap= here instead does anything (namely, wrap if it gets too long), but it's better than what was happening before.
[ci skip] Makes it clear it's not intrinsically tied to the Accelerated Speed factor.
This might not be needed anymore now that we no longer have a framebuffer surface.
"Fake interactive" mode seems like it was meant to be an interactive version of fake mode. However, since we're using it to stop the UI drawing and the unit tests (which use it) don't seem to display a window at all (not entirely sure why), it's weird that "fake interactive" mode would be considered interactive.
Also confirmed via PM with beetlenaut that they can be removed, and aren't supposed to still be there.
this fixes some rare cheats in mp.
previously players had to leave an rejoin the game to change their faction. this was most annoying in coop games where you want might want to choose your faction in consultation with the other players. Also you previously could not even checkout the different available factions again after you joined the game.
in the non-host case the clients might get updates that change the [side] config while the flg dialog is open which might result in invalid pointers, note that flg_manager::default_leader_cfg_ is still there but this is no problm because that is never dereferenced it's only compared to other pointers. we also make a copy of all [multiplayer_side] on the non hosts side for the same reason.
code it as & to avoid a pango warning in stderr 3ec26df changed it previously to '+' to work around that warning also change it for the untranslatable strings in the credits [ci skip]
This new implementation works more reliably, avoids spawning subshells, and is faster.
This covers the wall torch, the campfire, and the brazier.
|
If sconces illuminate, then Xol (Lit Stone Wall) probably should do too. Having Xol illuminate means that, if a new player follows the recommended campaign order, scenario 3 of AToTB will be the first scenario when they encounter this. That's possibly a good thing, if #3389 is accepted then AToTB S3 it becomes the main scenario for explaining how local time areas affect the game. If #3389 isn't accepted then I echo sevu's comment in #3056, "A hint in some way would probably not be bad, as [TSG]'s a newbie campaign". AToTB S3 also has an ^Ebn (Lit Brazer), but that hex isn't likely to see combat, whereas the Xol hexes definitely will. |
|
Argh, Xol would be the wall, it's the hexes south, south-east and south-west of the Xol that would need the illumination. |
|
I don't think terrain-based illumination like this supports spreading into adjacent hexes, so I guess lit stone wall would need to be handled by a time area instead. |
|
|
|
This PR needs to be rebased from old master to new master. |
|
Or it could simply be cherry-picked, since it's a single commit. |
|
GregoryLundberg
added
the
Needs Rebase
|
@GregoryLundberg |
|
Cherry picked to master and 1.14 |
|
this cannot go into 1.14 since it casues OOS (unit will haev differtn attack strength on clients runniong different versions) |
|
OK. Revert it. Or I'll get to it later. |
This reverts commit 71de6da. Will cause OOS: #3457 (comment)
|
Reverted |
Fire illuminates, so it's always weird to see one of these without a corresponding gameplay effect.