Various Python cleanup in wmltools-related code #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And minor nearby whitespace fixes.
* Fix lots of spacing to be PEP8 compliant * Use collections.defaultdict to simplify some code * Use dict.get() to simplify some code * Use plain set() to create a new set * Don't create unnecessary tuples for string formatting
Using the built-in basestring.
Skips an unecessary for loop and if conditional.
legoktm
force-pushed
the
wmltools-cleanup
branch
from
95a84bb
to
bd23c32
Compare
Elvish-Hunter
added a commit
that referenced
this pull request
Jul 27, 2015
Various Python cleanup in wmltools-related code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small things I noticed while trying to read and understand the code.