Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to deprecation logging and deprecate --userdata-dir=relative-path #4449

Merged
merged 3 commits into from Oct 15, 2019

Conversation

@jostephd
Copy link
Member

jostephd commented Oct 11, 2019

See individual commit messages for details.

I'd like to backport the wesnoth.cpp and deprecated.cpp parts. I'm not sure if I should backport the filesystem.cpp changes too.

The filesystem.cpp part is for issue #2000.

jostephd added 3 commits Oct 11, 2019
Needed if parsing any other command line flags logs any warnings, as the commit after next does
They're interpreted relative to $HOME. In 1.16 we'll make that
deprecated. In 1.17 we'll interpret them relative to cwd, like the
rest of the world.

Issue #2000
@jostephd

This comment has been minimized.

Copy link
Member Author

jostephd commented Oct 11, 2019

Just noticed that with this change, when I run ./wesnoth -cHeir_To_The_Throne '--campaign-difficulty=3' '--campaign-scenario=19c_Cliffs_of_Thoria' --debug I get warnings about various deprecations, such as:

Invalid WML found: wesnoth.delay has been deprecated indefinitely.
Invalid WML found: wesnoth.deselect_hex has been deprecated indefinitely.
Invalid WML found: wesnoth.is_skipping_messages has been deprecated indefinitely.
Invalid WML found: wesnoth.show_message_dialog has been deprecated indefinitely.
Invalid WML found: wesnoth.skip_messages has been deprecated indefinitely.

These are all from core.lua. The warnings go away if I either remove --debug, set the show_deprecation hidden preference to false, or revert this change (any one of the three).

That hidden preference is off by default so I guess this is actually a good thing, anyone who sets that preference has opted in to chattiness.

@jostephd jostephd merged commit 8e10241 into wesnoth:master Oct 15, 2019
4 checks passed
4 checks passed
greeting
Details
label
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jostephd added a commit that referenced this pull request Oct 15, 2019
@stevecotton

This comment has been minimized.

Copy link
Contributor

stevecotton commented Oct 16, 2019

The commit where this merged to 1.14 seems to coincide with AppVeyor builds failing like this:
WML_tests.cmd : error WML1: Test 'cve_2018_1999023' returned 1, expected 0 [C:\projects\wesnoth\projectfiles\VC12\wesnoth.vcxproj]

A separate error, Error sending Webhook notification: Error calling webhook http://ai0867.net:6661/wesnoth: An error occurred while sending the request. doesn't make the build count as failed, it was already happening on the preceding AppVeyor build.

@jostephd

This comment has been minimized.

Copy link
Member Author

jostephd commented Oct 16, 2019

The commit where this merged to 1.14 seems to coincide with AppVeyor builds failing like this:

I can't see how this change could cause that, and if the error happens on windows only I can't debug it either. Maybe the tests on windows run wesnoth --debug and there's a level 1 deprecation warning on stderr that makes the test fail?

Anyway, could you open a new issue please, milestone 1.14.10 and blocker? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.