Fix TODO by removing workaround for a resolved SDL issue. #451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462794 was reported and fixed in 2008. The issue was reported fro libsdl 1.2.13, the latest/last version was 1.2.15. Debian is still shipping 1.2.13, but have applied a patch to fix the issues. I would also expect that other platforms will also have resolved this issue since if they are still shipping that version of the library.
|
As I said on IRC, since we still support building with the affected versions of SDL (as per INSTALL), we should keep this workaround in place since it doesn't really harm anything anyway. Once we move to SDL 2 we can drop this along with the rest of the SDL 1.2 compatibility code. Marking as postponed. |
|
Is this still postponed since we're primarily using SDL2 on master now? |
|
Yes. I'll resolve this when sdl1 is removed. —Reply to this email directly or view it on GitHub. |
|
To merge now? |
|
It should be safe to merge now. |
Vultraz
added a commit
that referenced
this pull request
Mar 13, 2016
Fix TODO by removing workaround for a resolved SDL issue.
CelticMinstrel
removed
the
Postponed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=462794 was reported and fixed in 2008. The issue was reported fro libsdl 1.2.13, the latest/last version was 1.2.15. Debian is still shipping 1.2.13, but have applied a patch to fix the issue. I would also expect that other platforms will also have resolved this issue since if they are still shipping that version of the library.