Replace fog and shroud in map files #5430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"../../data/multiplayer/maps/6p_Team_Survival.map", line 2: warning, fog or shroud in map file "../../data/multiplayer/maps/Dark_Forecast_drought.map", line 2: warning, fog or shroud in map file "../../data/multiplayer/maps/Dark_Forecast_firstsnow.map", line 2: warning, fog or shroud in map file "../../data/multiplayer/maps/Dark_Forecast_secondsnow.map", line 2: warning, fog or shroud in map file
github-actions
bot
added
the
MP
|
What issue is that fixing other than the wmllint message? |
|
Only a wmllint message as far as I can tell. Fixing wmllint errors is important. fewer errors=less noise=wmllint becomes a more useful tool |
|
Sure, so if there is no actual issue why not remove the wmllint message instead? |
|
We could ask the people who added the rule to wmllint. 9814777#diff-2a47ac9772f0f3b50faf9387a746df6423bda6f870585aa06d079c7fbd8db5bdR1141 ab95662#diff-2a47ac9772f0f3b50faf9387a746df6423bda6f870585aa06d079c7fbd8db5bdR2886 @eric-s-raymond , @Elvish-Hunter , why are "fake fog" and "fake shroud" banned from map files? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the following wmllint errors: