Delete the list of hotkeys from the manual

[hexagonrecursion]

As pointed out in #1038 the list of hotkeys is too hard to keep up to date.

[hexagonrecursion]

The following are currently not listed in preferences->hotkeys

• Escape (Exit game, exit menu, cancel message)
• Holding Shift (Toggle between accelerated and normal game mode while pressed (temporary!))
• 1-7 (Show how far currently selected unit can move in that many turns)

Not sure if this one even works:

• F5 Refresh Cache

[hexagonrecursion]

What precisely is the difference between "m Message another player (in multiplayer)" and "Alt+m Message everyone in the game (in multiplayer)"?

[stevecotton]

What precisely is the difference between "m Message another player (in multiplayer)" and "Alt+m Message everyone in the game (in multiplayer)"?

It unchecks the "to team only" checkbox, if I recall correctly.

[Pentarctagon]

F5 does, or definitely should, work - it's used to update the WML loaded by the game from the main menu rather than needing to restart Wesnoth.

[stevecotton]

Instead of deleting this section, I'm thinking we should delete whole file, after a last check that everything in it is already in the in-game help.

[hexagonrecursion]

What precisely is the difference between "m Message another player (in multiplayer)" and "Alt+m Message everyone in the game (in multiplayer)"?

It unchecks the "to team only" checkbox, if I recall correctly.

• I do not see a checkbox.
• In my testing (1.15.8) all three send a message to every player. Will try reproducing on master

[stevecotton]

Urgh, just wasted an hour or so trying to work out when that was removed, only to find that the checkbox is only shown in MP games when there's another player on the same team who's connected via the network. If the checkbox isn't shown then the message is sent to all players, no matter which shortcut was used for opening the text input prompt.

That's controlled by the has_friends() call here, and it's been this way since Wesnoth 1.1.3 (circa 15 years ago):

wesnoth/src/menu_events.cpp

Lines 205 to 212 in a924706

	void menu_handler::speak()
	{
	textbox_info_.show(gui::TEXTBOX_MESSAGE, _("Message:"), has_friends()
	? board().is_observer()
	? _("Send to observers only")
	: _("Send to allies only")
	: "", preferences::message_private(), *gui_);
	}

[CelticMinstrel]

One think you might be missing about F5 is that it only works at the title screen (and I think in the map editor as well). It doesn't work during a game.

The Escape key can't be rebound, as I recall, so perhaps it alone deserves special mention in the game manual. (And I don't support deleting the game manual, for the record.)

I'm not sure about 1-7… it could be possible to allow customizing them, but that'd be kinda a pain since it's seven (or maybe even nine?) different hotkeys, one for each possible range. There could maybe be a new mechanic for exposing this information instead, possibly involving the scroll wheel or something.

Maybe "Scroll to Leader" would be better than "Center on Leader"?

[hexagonrecursion]

Maybe "Scroll to Leader" would be better than "Center on Leader"?

Done.

I don't support deleting the game manual

I'd like to focus on this one section for now.

[stevecotton]

I think this is good and should be merged, but feel I'm the wrong person to review it. I'm only listed as a reviewer because I previously left review comments.

[Pentarctagon]

@hexagonrecursion can you squash the cpp changes?

[hexagonrecursion]

Done

[Pentarctagon]

The change itself looks pretty straight forward, so I'll merge this tomorrow unless there are objections.