Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-ons manager: show tags in the details panel #5774

Merged
merged 2 commits into from May 15, 2021

Conversation

stevecotton
Copy link
Contributor

Show the contents of PblWML's "tags" attribute in the add-ons dialog. They're
shown at the bottom of the right-hand panel (only if the window size is large
enough to trigger that dialog's two-panel layout).

This started as part of #5765, I've split it because I think this part is ready to
merge, but the filtering-by-tags part needs an inspiration about the descriptive
strings.

@stevecotton stevecotton self-assigned this May 11, 2021
@github-actions github-actions bot added Add-ons Issues with the add-ons client and/or server. UI User interface issues, including both back-end and front-end issues. labels May 11, 2021
@Pentarctagon
Copy link
Member

A screenshot would be useful.

@stevecotton
Copy link
Contributor Author

wesnoth_tags_shown

Show the contents of PblWML's "tags" attribute in the add-ons dialog. They're
shown at the bottom of the right-hand panel (only if the window size is large
enough to trigger that dialog's two-panel layout).
Copy link
Member

@irydacea irydacea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@stevecotton stevecotton requested review from Vultraz and removed request for Pentarctagon May 14, 2021 09:44
@stevecotton stevecotton merged commit 7f53aa0 into wesnoth:master May 15, 2021
@stevecotton stevecotton deleted the show_addon_tags branch May 15, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Add-ons Issues with the add-ons client and/or server. UI User interface issues, including both back-end and front-end issues.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants