Fix deprecation of [advancefrom], mark as already removed #6482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code searched for `[units][advancefrom]` instead of `[unit_type][advancefrom]`, so wasn't triggering. It was planned for removal in 1.17, so simply mark it as already-removed in 1.15.3. The deprecation warning is shown on stdout/stderr, but not in the in-game UI, so it's generally not visible to players. I think it would be better if it was visible, but OTOH it's something that's easy for someone to check all add-ons for with a simple grep. (cherry picked from commit f2fa807)
stevecotton
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-port of #6425, planning to just run the CI and then merge immediately.
Closes #6204.
The existing code searched for
[units][advancefrom]instead of[unit_type][advancefrom], so wasn't triggering. It was plannedfor removal in 1.17, so simply mark it as already-removed in 1.15.3.
The deprecation warning is shown on stdout/stderr, but not in the
in-game UI, so it's generally not visible to players. I think it
would be better if it was visible, but OTOH it's something that's
easy for someone to check all add-ons for with a simple grep.
(cherry picked from commit f2fa807)