Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation of [advancefrom], mark as already removed #6482

Merged
merged 1 commit into from
Feb 2, 2022

Commits on Feb 2, 2022

  1. Fix deprecation of [advancefrom], mark as already removed

    The existing code searched for `[units][advancefrom]` instead of
    `[unit_type][advancefrom]`, so wasn't triggering. It was planned
    for removal in 1.17, so simply mark it as already-removed in 1.15.3.
    
    The deprecation warning is shown on stdout/stderr, but not in the
    in-game UI, so it's generally not visible to players. I think it
    would be better if it was visible, but OTOH it's something that's
    easy for someone to check all add-ons for with a simple grep.
    
    (cherry picked from commit f2fa807)
    stevecotton committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5e448f6 View commit details
    Browse the repository at this point in the history