Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor req cleanup #6557

Merged
merged 2 commits into from Mar 9, 2022
Merged

Minor req cleanup #6557

merged 2 commits into from Mar 9, 2022

Conversation

Vultraz
Copy link
Member

@Vultraz Vultraz commented Mar 9, 2022

For CI.

@Vultraz
Removed unused boost::assign and boost::multi-array includes and deps
e6ff517 
boost::assign was removed a long time ago, and the only use of boost::multi-array was unused and removed in 9cf445e.
@Vultraz
Don't link with boost::thread
b2db5d0
@github-actions github-actions bot added Building Build-time issues. CMake Issues involving the CMake build system. Terrain Issues that involve terrain definitions or their implementation in the engine. labels Mar 9, 2022
@stevecotton
Copy link
Contributor

I think this one too, but I haven't done a build to confirm that it can be removed:

SConstruct:     conf.CheckBoost("thread") & \

@github-actions github-actions bot added the SCons Issues involving the SCons build system. label Mar 9, 2022
@Vultraz
Copy link
Member Author

Vultraz commented Mar 9, 2022

Ok, so the scons change breaks things??

@Vultraz Vultraz merged commit ae79f74 into master Mar 9, 2022
@Vultraz Vultraz deleted the minor_req_cleanup branch March 9, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Building Build-time issues. CMake Issues involving the CMake build system. SCons Issues involving the SCons build system. Terrain Issues that involve terrain definitions or their implementation in the engine.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vultraz @stevecotton