Remove gui/auxiliary/filter.hpp and unused includes of pane.hpp #6558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove filter.hpp, which wasn't included by any file, and relied on pane.hpp indirectly via one of the lines removed in this commit. The sorting functionality seems to have moved into pane.cpp when matrix.hpp was added. Note: there are two other unrelated `filter.hpp` files. Header pane.hpp is only used by matrix.hpp, pane.cpp, and window_builder.cpp; the class is also used via a forward-declaration in window.hpp, which friends it, allowing a call to window::layout_linked_widgets. The class is also made accessible via REGISTER_WIDGET. Part of wesnoth#6540.
github-actions
bot
added
Add-ons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove filter.hpp, which wasn't included by any file, and relied on
pane.hpp indirectly via one of the lines removed in this commit. The sorting
functionality seems to have moved into pane.cpp when matrix.hpp was added.
Note: there are two other unrelated
filter.hppfiles.Header pane.hpp is only used by matrix.hpp, pane.cpp, and window_builder.cpp;
the class is also used via a forward-declaration in window.hpp, which friends
it, allowing a call to window::layout_linked_widgets. The class is also made
accessible via REGISTER_WIDGET.
Part of #6540.