New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NR S05a_01 Enhance dialogue between Tallin and Abhai #6612
NR S05a_01 Enhance dialogue between Tallin and Abhai #6612
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to not make a concise line of dialogue into 3 that we have to click through. "Pales if possible" is definitely wrong but you can change that in a number of other ways as you see fit.
[/message] | ||
|
||
[message] | ||
speaker=Tallin | ||
message= _ "Can you tell us where he is? And, if I may ask, who are — or rather, were — you?" | ||
message= _ "(<i>To himself</i>) <i>Pronouncing Malifor’s name seems to have made the apparition get even more pale, if that is at all possible.</i> (<i>Looking at the wraith</i>) Can you tell us where he is? And, if I may ask, who are — or rather, were — you?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still a bit wordy, maybe something like this is better:
message= _ "(<i>To himself</i>) <i>Pronouncing Malifor’s name seems to have made the apparition get even more pale, if that is at all possible.</i> (<i>Looking at the wraith</i>) Can you tell us where he is? And, if I may ask, who are — or rather, were — you?" | |
message= _ "<i>Is it just me or did this spirit get even paler?</i> Can you tell us where he is? And, if I may ask, who are — or rather, were — you?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I understand, in that case I would reduce it even further, to something like:
Did this spirit get even paler?
[/message] | ||
|
||
[message] | ||
speaker=Tallin | ||
message= _ "Can you tell us where he is? And, if I may ask, who are — or rather, were — you?" | ||
message= _ "<i>Did this spirit get even paler?</i> Can you tell us where he is? And, if I may ask, who are — or rather, were — you?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translators will see this out of context, possibly worth adding # po: "spirit" meaning ghost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and did it in a more precise way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would separate the two questions, not putting them on consecutive lines of the same message. One doesn't ask two questions in immediate sequence without a pause to ponder the first one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, "pale spirit" is a bit confusing, it's alluding to some sort of symbolic/moral aspect rather than the physicality, i.e. the wraith's spirit is paler as opposed to the wraith being paler. I realize that's not what you meant, but that's what it sounds like.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions in one line is odd, but I think it fits the flow here - Tallin first asks the question related what he's currently trying to do, and then realises that he needs to build rapport with the new-found source of information first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but I'd let him have a piece of dialog to himself, then for the user to press next/ok, then for him to talk to somebody else. So there's pause.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would separate the two questions, not putting them on consecutive lines of the same message. One doesn't ask two questions in immediate sequence without a pause to ponder the first one.
One of them is a thought, to himself, and that is marked by the italic font. In game, you would not read them back to back with the same voice, you would unconsciously separate them, because one question is in italics and the next is not.
Also, "pale spirit" is a bit confusing, as if it was alluding to some sort of symbolic/moral aspect rather than the physicality.
I think the context clears that up, as you were talking to a ghost, and there would not be a subject for that moral reference. (e.g. Tallin's units, himself, Abhai... would not be referenced, not even by context for that moral aspect to make sense). To clear things up, for that to happen, in my opinion, the subject should be there in a sentence similar to:
Did this wraiths' spirit get even paler?
Did his spirit get even paler?
Did my men's spirit get even paler?
And that does not happen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including the unspoken thought, there's three questions in this line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including the unspoken thought, there's three questions in this line.
Uhhhh, true, but that was an issue before aswell then, as the two spoken questions have not been changed. I'd say that would be something to be considered in another issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as you were talking to a ghost,
The adjective "pale" does not apply to the noun "ghost", IMHO.
As for @stevecotton 's comment - before, it was 2 questions, now it's 3.
As for whether to file another issue - if we agree here on some text, we can always file another issue, that's not the point...
I see it's approved, is there anything left to do before merging? String-freeze for 1.16.3 will be on Saturday, so if it's going to be backported then we should do it soon. |
Not from me, it can be merged as long as that po comment is sufficient for you. |
Squash before merging.
Closes #6608