Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NR S05a_01 Enhance dialogue between Tallin and Abhai #6612

Merged
merged 7 commits into from
Apr 8, 2022
Merged

NR S05a_01 Enhance dialogue between Tallin and Abhai #6612

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f07eaa9
changelog
Descacharrado Apr 5, 2022
4d5c46a
Move the comment about the ghost being pale to a narrator message
Descacharrado Apr 5, 2022
84bcbe9
whitespace
Descacharrado Apr 5, 2022
6626373
whitespace 2
Descacharrado Apr 5, 2022
94ad016
Another possibility of dialogue
Descacharrado Apr 5, 2022
2595b19
new implementation
Descacharrado Apr 6, 2022
382ef56
po hint
Descacharrado Apr 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,9 @@
* Descent into Darkness
* S08: Prevent Spectral Servant from picking up the book (issue #6576)
* Northern Rebirth
* S05a_01: Solve units getting stuck in the wall before the spider chamber (issue #6607)
* S05a_01:
* Solve units getting stuck in the wall before the spider chamber (issue #6607)
* Enhance dialogue between Tallin and Abhai (issue #6608)
### Editor
### Multiplayer
### Lua API
Expand Down
4 changes: 2 additions & 2 deletions data/campaigns/Northern_Rebirth/scenarios/05a_01_The_Pursuit.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2124,12 +2124,12 @@

[message]
speaker=Abhai
message= _ "(<i>pales if possible</i>) Malifor...! Finally someone here in force to deal with that menace!"
message= _ "Malifor...! Finally someone here in force to deal with that menace!"
[/message]

[message]
speaker=Tallin
message= _ "Can you tell us where he is? And, if I may ask, who are — or rather, were — you?"
message= _ "<i>Did this spirit get even paler?</i> Can you tell us where he is? And, if I may ask, who are — or rather, were — you?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The translators will see this out of context, possibly worth adding # po: "spirit" meaning ghost

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and did it in a more precise way.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would separate the two questions, not putting them on consecutive lines of the same message. One doesn't ask two questions in immediate sequence without a pause to ponder the first one.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, "pale spirit" is a bit confusing, it's alluding to some sort of symbolic/moral aspect rather than the physicality, i.e. the wraith's spirit is paler as opposed to the wraith being paler. I realize that's not what you meant, but that's what it sounds like.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions in one line is odd, but I think it fits the flow here - Tallin first asks the question related what he's currently trying to do, and then realises that he needs to build rapport with the new-found source of information first.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I'd let him have a piece of dialog to himself, then for the user to press next/ok, then for him to talk to somebody else. So there's pause.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would separate the two questions, not putting them on consecutive lines of the same message. One doesn't ask two questions in immediate sequence without a pause to ponder the first one.

One of them is a thought, to himself, and that is marked by the italic font. In game, you would not read them back to back with the same voice, you would unconsciously separate them, because one question is in italics and the next is not.

Also, "pale spirit" is a bit confusing, as if it was alluding to some sort of symbolic/moral aspect rather than the physicality.

I think the context clears that up, as you were talking to a ghost, and there would not be a subject for that moral reference. (e.g. Tallin's units, himself, Abhai... would not be referenced, not even by context for that moral aspect to make sense). To clear things up, for that to happen, in my opinion, the subject should be there in a sentence similar to:

Did this wraiths' spirit get even paler?
Did his spirit get even paler?
Did my men's spirit get even paler?

And that does not happen.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the unspoken thought, there's three questions in this line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Including the unspoken thought, there's three questions in this line.

Uhhhh, true, but that was an issue before aswell then, as the two spoken questions have not been changed. I'd say that would be something to be considered in another issue.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as you were talking to a ghost,

The adjective "pale" does not apply to the noun "ghost", IMHO.

As for @stevecotton 's comment - before, it was 2 questions, now it's 3.

As for whether to file another issue - if we agree here on some text, we can always file another issue, that's not the point...

[/message]

[message]
Expand Down