Unit tests: make separate files for each starting position #6627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turn the 4 side setup of the firststrike_and_laststrike test into a macro called `COMMON_KEEP_A_B_C_D`for reuse in other tests. The comment for `GENERIC_UNIT_TEST` gets a couple of extra paragraphs. All the files get wmlindent run on them, which reindents `FAIL_IF_NOT`. The main reason for having these is separate files is Git's fuzzy-patch matching when merging and rebasing. Having large blocks of identical text in `wml_unit_test_macros.cfg` can mean the wrong section gets patched.
Pentarctagon
approved these changes
Apr 18, 2022
This was referenced Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turn the 4 side setup of the
firststrike_and_laststriketest into a macrocalled
COMMON_KEEP_A_B_C_Dfor reuse in other tests.The comment for
GENERIC_UNIT_TESTgets a couple of extra paragraphs.All the files get wmlindent run on them, which reindents
FAIL_IF_NOT.The main reason for having these is separate files is Git's fuzzy-patch
matching when merging and rebasing. Having large blocks of identical text
in
wml_unit_test_macros.cfgcan mean the wrong section gets patched.