Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit tests: make separate files for each starting position #6627

Merged
merged 1 commit into from
Apr 18, 2022
Merged

Unit tests: make separate files for each starting position #6627

merged 1 commit into from
Apr 18, 2022

Commits on Apr 17, 2022

  1. Unit tests: make separate files for each starting position 

    Turn the 4 side setup of the firststrike_and_laststrike test into a macro
called `COMMON_KEEP_A_B_C_D`for reuse in other tests.

The comment for `GENERIC_UNIT_TEST` gets a couple of extra paragraphs.

All the files get wmlindent run on them, which reindents `FAIL_IF_NOT`.

The main reason for having these is separate files is Git's fuzzy-patch
matching when merging and rebasing. Having large blocks of identical text
in `wml_unit_test_macros.cfg` can mean the wrong section gets patched.
    @stevecotton
    stevecotton committed Apr 17, 2022
    Configuration menu
    Copy the full SHA
    8ea8cdb View commit details
    Browse the repository at this point in the history