New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EI S07a various fixes #6639
EI S07a various fixes #6639
Conversation
Found a small typo, adding to the batch without changelog because it is so minor. (a46c464) |
I think it's generally known that trolls are often characterised with incorrect or unusual grammar or word phrasing, but I suppose the po hint can't hurt. I would just say that the speak is a troll instead of saying 'weird speech pattern', but it can be left as it is for now. Also it's fine to update straight apostrophes to their curly equivalents without making note of it - I would say that's preferred, in fact. Go ahead and mark the review comments as resolved if you think they have been dealt with. |
Sorry for the potentially silly question, but what is hard-coding the co-ordinates for Gork and Drog supposed to do? I'm assuming a setting of |
It shows them on the map (useful, for example, in case the player skips text or does not pay too much attention). That idea was originally posted in the linked issue. |
I looked through the mentions of S7a (I remember this issue being a very big list) but didn't find the connection. Is it the case that |
Yes, thats it. |
Looks good to me, but I'm not sure who should approve. I'd guess @nemaara. |
Along with #6644, will have to wait for string freeze to be over before back-porting this. |
* Side 2 hidden without spoilers * Fixed Grug upkeep, added dialogue about Ogres joining * typographic quote (cherry picked from commit 742bb75)
Addresses some points in #4145.
Side 2 was spoiled previously in two ways:
Now the status table at turns 1 and 2 will be:
And the leader is stored in the prestart event to ensure that it is not leaked.
Also, the player will now be notified that two more ogres are joining Gweddry (both with dialogue and visually) and Grug will have no upkeep (fixed by deleting the [modifications] tag).
Squash before merging.
P.S. If you want to test this, keep in mind you need Owaec from S05 to trigger the victory condition.