Fix single-frame title-screen flicker when loading a game or starting a campaign. #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was being displayed for a single frame in between loading dialogs.
github-actions
bot
added
the
UI
|
I think that was a known issue - was it formally recorded (and therefore should be closed)? Or perhaps not... |
|
I searched but didn't find an open issue for it. Could be it was small and obvious enough that nobody bothered to report it. |
|
No worries, wasn't asking you specifically. Thanks for resolving the issue! PS @Vultraz Could/should this be back-ported (if it's not already)? |
|
Never mind, found it in #2395. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The title screen was being displayed for a single frame in between loading dialogs when either starting a new campaign or loading a game.
This was giving me an aneurysm.
I just turned off drawing of the title screen after these processes are confirmed. The next time the title screen needs to be drawn, it is recreated from scratch anyway, so the existing instance should never actually need to redraw.