1.17 undead sprite cleanup #6655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Graphics
20 tasks
knyghtmare
added a commit
to knyghtmare/wesnoth
that referenced
this pull request
Apr 30, 2022
incorrect image path after merger of wesnoth#6655 so patching it
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also does a bunch of questionable
translatable string changes like translating "<span color='#ff7722'>".
So for now, instead of using wmllint, just update Aethermaw for these
renamed images as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also makes an enormous number of
other (often questionable at best) changes (issue wesnoth#5799). So for now,
instead of using wmllint, just update Aethermaw for these renamed images
as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also makes an enormous number of
other (often questionable at best) changes (issue wesnoth#5799). So for now,
instead of using wmllint, just update Aethermaw for these renamed images
as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
This was referenced Feb 20, 2024
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also makes an enormous number of
other (often questionable at best) changes (issue wesnoth#5799). So for now,
instead of using wmllint, just update Aethermaw for these renamed images
as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also makes an enormous number of
other (often questionable at best) changes (issue wesnoth#5799). So for now,
instead of using wmllint, just update Aethermaw for these renamed images
as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
Wedge009
added a commit
to Wedge009/wesnoth
that referenced
this pull request
Feb 20, 2024
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also makes an enormous number of
other (often questionable at best) changes (issue wesnoth#5799). So for now,
instead of using wmllint, just update Aethermaw for these renamed images
as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
pehjota
added a commit
to pehjota/wesnoth
that referenced
this pull request
Feb 20, 2024
Playing the multiplayer scenario Aethermaw as Loyalists vs. Undead
revealed some image errors:
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-1.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-s-attack-4.png'
20240219 06:50:21 error image: could not open image 'units/undead/shadow-n-3.png'
20240219 06:50:22 error image: could not open image 'units/undead/shadow-n-attack-2.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-9.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-se-10.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/spearman-attack-s-6.png'
20240219 06:50:26 error image: could not open image 'units/human-loyalists/general-idle-5.png'
units/undead/shadow-* images were moved to units/undead-spirit/shadow-*
in 1.17.4 commit a2ad3ae, specifically the "1.17 undead sprite
cleanup" commit 961b8a3 of PR wesnoth#6655. This was documented on the
forums:
https://forums.wesnoth.org/viewtopic.php?p=684291&hilit=units%2Fundead-spirit%2F#p684291
wmllint handles renamed images, but it also makes an enormous number of
other (often questionable at best) changes (issue wesnoth#5799). So for now,
instead of using wmllint, just update Aethermaw for these renamed images
as follows (requires GNU sed):
git grep -Fl -- 'units/undead/shadow-' \
| grep -v '^data/tools/wmllint$' \
| xargs sed -i 's|units/undead/shadow-|units/undead-spirit/shadow-|'
These units/human-loyalists/ images were removed in 1.17.12 commit
8e38cfd, specifically the "spearman image cleanup" commit 775e7f8
and the "remove left-over old general frames" commit e07d554 in
PR wesnoth#7208. But Aethermaw still uses them.
Restore the removed images that are still used:
git grep -EIh -- '^[^#]*[{]PLACE_IMAGE[^ ]* +[(]?"?[^{}$ ~")]+[ ~")].*$' data/ \
| sed -E 's|^.*[{]PLACE_IMAGE[^ ]* +[(]?"?([^{}$ ~")]+)[ ~")].*$|\1|' \
| while read -r img; do
[ -e data/core/images/${img} ] && continue
[ -e data/campaigns/*/images/${img} ] && continue
[ -e ${img} ] && continue
git show 8e38cfd~1:data/core/images/${img} 1>data/core/images/${img}
done
Also add a CI check to prevent this from happening in the future.
Example output without these Aethermaw fixes:
data/multiplayer/scenarios/2p_Aethermaw.cfg:134: missing image: units/undead/shadow-s-attack-1.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:135: missing image: units/undead/shadow-n-attack-2.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:147: missing image: units/undead/shadow-n-3.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:149: missing image: units/undead/shadow-s-attack-4.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:196: missing image: units/human-loyalists/spearman-attack-se-10.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:197: missing image: units/human-loyalists/spearman-attack-s-6.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:198: missing image: units/human-loyalists/spearman-attack-se-9.png
data/multiplayer/scenarios/2p_Aethermaw.cfg:203: missing image: units/human-loyalists/general-idle-5.png
Wedge009
added a commit
that referenced
this pull request
Feb 21, 2024
Wedge009
added a commit
that referenced
this pull request
Feb 21, 2024
(cherry picked from commit a59c32f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #6417 - completed
The ghosts were interesting; all of them were good sprites, but there was an evolution ending with the spectre, which is really top-shelf. If all sprites were like the spectre, this whole cleanup project would be unneeded.