New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command suggestions #6688
Merged
Vultraz
merged 14 commits into
wesnoth:master
from
Descacharrado:Approximate_string_distance
May 13, 2022
Merged
Add command suggestions #6688
Vultraz
merged 14 commits into
wesnoth:master
from
Descacharrado:Approximate_string_distance
May 13, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
WFL
Issues involving the Wesnoth Formula Language engine and APIs.
label
May 6, 2022
CelticMinstrel
requested changes
May 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I can't believe no-one has thought to do this before. I see a few small issues that need addressing, though (see specific comments below).
CelticMinstrel
approved these changes
May 7, 2022
Vultraz
requested changes
May 7, 2022
Wedge009
added
the
UI
User interface issues, including both back-end and front-end issues.
label
May 9, 2022
Vultraz
reviewed
May 9, 2022
Vultraz
reviewed
May 9, 2022
Vultraz
reviewed
May 9, 2022
Vultraz
reviewed
May 9, 2022
Vultraz
reviewed
May 9, 2022
Vultraz
approved these changes
May 13, 2022
It looks like this can be merged then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes suggestions when a command is misspelled as seen below.
*works in mp chats too.
Explanation:
Other commands will be recommended when a third or less of the letters (of the shortest string, either player input or actual command) are wrong. Additions, deletions, swaps and changes all count as 1 error (1 wrong letter).
The change comes from #6421 (comment) which comes from #1018
Needless to say that the implementation and thresholds are not set in stone, I even pushed all the commits so anyone can follow along the development to better understand my decisions.