Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NR S1 Vary the die dialog depending on race #6737

Merged
merged 3 commits into from Jun 1, 2022

Conversation

Descacharrado
Copy link
Contributor

Closes #6735

The new strings are not set in stone.

@github-actions github-actions bot added the Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign label May 31, 2022
@Pentarctagon Pentarctagon requested a review from nemaara May 31, 2022 17:05
@Wedge009 Wedge009 added the Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. label Jun 1, 2022
@Wedge009
Copy link
Member

Wedge009 commented Jun 1, 2022

Works for me. Subtle issue - I suppose most players/testers never wound up in the situation where the rival orcs killed each other.

@Wedge009 Wedge009 merged commit 481378a into wesnoth:master Jun 1, 2022
@Wedge009
Copy link
Member

Wedge009 commented Jun 1, 2022

Ah, shoot, forgot to squash. Not a big deal, I hope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport A reminder of a bugfix that was added to master that needs to be duplicated on the stable branch. Campaign (any) Deprecated tag, replaced with separate tags for each mainline campaign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NR] In S1, when an orc kills an enemy leader, the dialog is as if a slave killed it
3 participants