Texture speedups #6762
Merged
Texture speedups #6762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Campaign (any)
The game should work now on Wayland, although depending on SDL version may not have any window decorations.
CVideo::set_clip -> draw::set_clip CVideo::set_render_target -> draw::set_render_target etc.
screen_pitch_microns is deprecated, and has been removed from the GUI_SCALE_RESOLUTION macro in WML. The macro itself has been left in place for potential future use. The screen_pitch_microns variable has been left in place, but is now a constant and will only ever return the default value equivalent to 96 DPI.
The texture-only code was missing huge sections, and otherwise a direct duplication. If it is desired that surfaces do not get cached when loading textures, then an option should be added to get_surface to explicitly disable caching.
Previously it was doing all sorts of things using surface operations. This is a stop-gap measure. If possible, these operations should eventually moved into graphics shaders.
Images are scaled when drawn. Also introduced image::get_image_size() to return the size of an image without returning the full surface or texture. It will still load and cache the image if it can't find it in the cache.
Images are scaled when drawn.
This is under a new "image" logging domain. Most other log calls in image:: were also moved to this domain.
These were not being meaningfully used. Also removed code flushing image caches when zoom level changes. This is not necessary now that images are scaled on demand.
mesilliac
force-pushed
the
texture_speedups
branch
from
6794b10
to
0093d64
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulled out the image caching stuff from new_rendering (excluding text caching).
Should bring performance back up to scratch in most cases.