Canvas cleanup #6804
Merged
Canvas cleanup #6804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viewports now manage the clipping rectangle when set and unset, converting it to the viewport coordinate space. Some improvements were also made to handling when clipping is disabled.
Text is still drawing clipped because otherwise Credits crashes. It has bugs because the viewport is too large, but at least it doesn't crash.
I didn't take too close a look at what that weird cache was doing, but I recall last time I did this concluding it didn't do much of anything at all.
These were added in 8f945cf, but since the "new" listbox implementation never came to be, these have just been unused clutter. There was one place they were used as parameters in a manual call to calculate_blitting_rectangle, but that was refactored out in db17177. This also removes an overload of widget::draw_debug_border, since without the offsets, both functions now did the same thing. This affects: * widget::draw_background * widget::draw_children * widget::draw_foreground * widget::impl_draw_background (offset overload removed) * widget::impl_draw_children * widget::impl_draw_foreground * widget::calculate_blitting_rectangle * widget::calculate_clipping_rectangle * widget::draw_debug_border
github-actions
bot
added
the
UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulling most of the canvas cleanup out of the
new_renderingbranch.This fixes #6787 , or at least it puts it back to the state it was in before. The GUI is still using the wrong layout at those resolutions, but it won't go all black.
This also introduces bugs with the credits screen. I managed to get it at least not crashing, but it looks terrible. That can't be fixed without overhauling the credits screen to not try to draw 80000 pixels worth of text all at once. It's not trying to draw all that here, but the way the canvas overhaul was set up, it still can't handle the size even if it only draws a small amount.
I left out the massive removal of dirty widget handling code.
I also had to completely overhaul how viewport setting works to micromanage clipping regions. It was not pleasant. I am not a fan of viewports.