Minor SDL interface tidy up #6809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
UI
Vultraz
approved these changes
Jun 28, 2022
Functions have moved to draw.hpp and sdl/texture.hpp as appropriate. Most of these had already moved. set_texture_blend_mode() was the last uncategorized function. It is now in texture.hpp.
sdl_copy_portion (only used one place internally, so inlined there) stretch_surface_horizontal (obsoleted by hardware rendering) stretch_surface_vertical (obsoleted by hardware rendering) tile_surface (obsoleted by hardware rendering) surface_submerge_alpha (now done via IPF) blit_surface (not used anywhere, so sdl_blit must be fine)
And then have to clean up over a dozen files that were relying on sdl/rect.hpp including sdl/utils.hpp and various other side effects.
gui/widgets/helper.*pp had an implementation creating a rectangle from points. It was added to sdl/rect.hpp.
mesilliac
force-pushed
the
sdl_render_cleanup
branch
from
6e1cbfc
to
9b9d30b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly removing unused or already recategorized functions, with some other general cleaning, organization and minor reshuffling.
Most of the mess is because sdl/rect.hpp was including sdl/utils.hpp and now no longer is. Turns out a lot was depending on that for its side effects.