Address various minor highdpi TODOs #6812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not used, and appears to have been unused for a long time. It was related to mouseover hex brightening, but the brightening amount is hardcoded. There were associated hex_semi_brightening, mouseover_image and selected_image keys, but that info is also hardcoded, and those keys appear to have been removed already.
github-actions
bot
added
Help
Wait this sounds like it could be used to address the "high contrast mode" part of #6133 perhaps? Or actually I guess that's #6149 now... |
|
It doesn't actually do anything. It was just a variable, sitting there. From the sounds of it all it was ever used for was tweaking the brightness of the hex underneath the mouse cursor, and it seems from the original commit in 2010 like it was for testing the effect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly these just involved checking if something was okay.
A couple unused things were removed.
hex_brighteningconfig option. This was not used, and from the looks of it has not been for quite some time. It was added in 2010 for testing the mouseover effect. The current effect is hardcoded and ignores this value.I originally thought "reports" were maybe some automatically generated graphs or something. But no. It is just the name for the automatically updated UI sections of the game display, such as the amount of village gold etc.. The icon images do not need clipping, and even if they do, it should be done via IPF.