Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #25332, some sentences are not shown in help pages #937

Merged
merged 3 commits into from
Feb 28, 2017
Merged

Fix bug #25332, some sentences are not shown in help pages #937

merged 3 commits into from
Feb 28, 2017

Conversation

fujimo-t
Copy link
Contributor

@fujimo-t fujimo-t commented Feb 25, 2017

fix bug #25332 https://gna.org/bugs/index.php?25332

render_text() separates sentences which use plural fonts to plural surfaces, but render_text() makes the surfaces invisible when blit surfaces.

adjust_surface_alpha with SDL_ALPHA_TRANSPARENT makes the surface transparent completely, so fix it
@Wedge009
Copy link
Member

This change seems to help for Japanese Help and doesn't seem to cause obvious issues with other languages. But I don't have a full understanding of what the change is doing with regards to transparency - if no-one else adds their feedback, I'll probably merge it.

@CelticMinstrel
Copy link
Member

If I recall correctly, @Vultraz changed adjust_surface_alpha in such a way that this won't actually perform a blit without blending. That's not necessarily a problem, but if I'm correct we'll at least want to remove the misleading comment.

@Wedge009
Copy link
Member

I haven't tested this last commit - presumably it no longer has any effect on the rendering.

@jyrkive
Copy link
Member

jyrkive commented Feb 28, 2017

I verified that some text seems to be missing in Japanese help in master, but not with these changes applied.

I also had a closer look at adjust_surface_alpha(). The function is NOP with SDL_APLHA_OPAQUE; calling it with that value is pointless. Thus, I approve the latest commit, and I'll make a commit that removes those unnecessary calls from everywhere.

Merging this PR. Arigatō! 👍

@jyrkive jyrkive merged commit c74fcca into wesnoth:master Feb 28, 2017
@fujimo-t fujimo-t deleted the fix_25332 branch March 2, 2017 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants