Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add set and remove alias functionality #30

Merged
merged 3 commits into from
Mar 31, 2020
Merged

Add set and remove alias functionality #30

merged 3 commits into from
Mar 31, 2020

Conversation

alejgh
Copy link
Member

@alejgh alejgh commented Mar 31, 2020

Closes #18

@codecov
Copy link

codecov bot commented Mar 31, 2020

Codecov Report

Merging #30 into master will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
+ Coverage   95.10%   95.35%   +0.25%     
==========================================
  Files          14       14              
  Lines         469      494      +25     
==========================================
+ Hits          446      471      +25     
  Misses         23       23              
Impacted Files Coverage Δ
hercules_sync/triplestore/wikibase_adapter.py 98.27% <100.00%> (+0.44%) ⬆️
hercules_sync/util/uri_constants.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 138a6a0...b4c4c92. Read the comment docs.

@alejgh
Copy link
Member Author

alejgh commented Mar 31, 2020

There is currently a problem when removing the last alias for a language of the entity. For example, if you have as aliases of Person ['subject', 'individual'], removing one of them works, but if you want to remove all the current aliases of Person, the operation is not made.

This is a bug of the wbeditentity API method: https://phabricator.wikimedia.org/T203337
That was resolved and should be working correctly from wmf 1.35.0 onwards. I will create a new issue to update to 1.35.0 whenever it is available in wikibase-docker, and check if this bug is fixed. For the moment, I will close this issue.

@alejgh alejgh merged commit c90f6d3 into master Mar 31, 2020
@alejgh alejgh deleted the issue_18_aliases branch March 31, 2020 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set and remove aliases
1 participant