add email backend tests #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+13
to
+17
| def relay_backend(): | ||
| with override_settings( | ||
| EMAIL_BACKEND="email_relay.backend.RelayDatabaseEmailBackend" | ||
| ): | ||
| yield |
There was a problem hiding this comment.
Feel free to keep your pattern, but I tend to use this syntax instead:
Suggested change
| def relay_backend(): | |
| with override_settings( | |
| EMAIL_BACKEND="email_relay.backend.RelayDatabaseEmailBackend" | |
| ): | |
| yield | |
| def relay_backend(settings): | |
| settings.EMAIL_BACKEND = "email_relay.backend.RelayDatabaseEmailBackend" |
jefftriplett
approved these changes
Sep 28, 2023
jefftriplett
force-pushed
the
add-backend-tests
branch
from
2533db7
to
4cc5557
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.