Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add healthcheck ping in relay service #56

Merged
merged 7 commits into from
Oct 25, 2023
Merged

add healthcheck ping in relay service #56

merged 7 commits into from
Oct 25, 2023

Conversation

joshuadavidthomas
Copy link
Member

@joshuadavidthomas joshuadavidthomas commented Oct 23, 2023 •
edited
Loading

closes #51

needs:

  • docs for installing package with django-email-relay[hc]
  • add [hc] to Dockerfile

@joshuadavidthomas joshuadavidthomas marked this pull request as draft October 23, 2023 21:38
jefftriplett
jefftriplett approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@jefftriplett jefftriplett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few comments about usage that came to mind.

@joshuadavidthomas joshuadavidthomas marked this pull request as ready for review October 25, 2023 16:32
@joshuadavidthomas joshuadavidthomas merged commit d559010 into main Oct 25, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jefftriplett jefftriplett jefftriplett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Relay service should have some sort of healthcheck
2 participants
@joshuadavidthomas @jefftriplett