Replace bower with npm #1330
Replace bower with npm #1330
Conversation
package.json
Outdated
| "dependencies": { | ||
| "fast-json-patch": "github:wet-boew/JSON-Patch#wb1.0+1.1.4", | ||
| "jsonpointer.js": "^0.4.0", | ||
| "wet-boew": "LaurentGoderre/wet-boew#themes-npm" |
There was a problem hiding this comment.
Replace this with upstream WET when wet-boew/wet-boew#8305 is merged
| @@ -183,8 +176,10 @@ module.exports = (grunt) -> | |||
| # Metadata. | |||
| pkg: @file.readJSON "package.json" | |||
| themeDist: "dist/<%= pkg.name %>" | |||
| jqueryVersion: @file.readJSON "lib/jquery/bower.json" | |||
| jqueryOldIEVersion: @file.readJSON "lib/jquery-oldIE/bower.json" | |||
| jqueryVersion: grunt.file.readJSON( | |||
There was a problem hiding this comment.
I did something "fancy" here in the upstream, but we could always just hardcode it like the OldIE one
There was a problem hiding this comment.
This works without hardcoding so it makes it easier to maintain
package.json
Outdated
| "devDependencies": { | ||
| "assemble-contrib-i18n": "~0.1.2", | ||
| "assemble-contrib-i18n": "0.1.*", |
There was a problem hiding this comment.
Not sure I get this change. Wouldn't these be equivalant, or is the ~ a problem because it hasn't hit a major version yet?
There was a problem hiding this comment.
I'm just making it consistent with WET core
script/setup
Outdated
| @@ -1,2 +1,2 @@ | |||
| #!/bin/sh | |||
| npm install -g bower grunt-cli && npm install | |||
| npm install -g grunt-cli && npm install | |||
There was a problem hiding this comment.
Is bower still needed for because of the prepare script in WET?
There was a problem hiding this comment.
Oh yeah it is for core.....But we can change core to not use it at all no?
|
@duboisp someone needs to a[pply this to all the other supported themes. |
Deprends on wet-boew/wet-boew#8305