-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Authentification A href VS button #2139
Authentification A href VS button #2139
Conversation
@Garneauma can you generate and post a link to a working example for this PR? Thank you. |
DTO will take a quick look to ensure it is conform to their guidance. Here a direct link to the newly added example: https://servicecanada.github.io/wet-boew-demos/gcweb-pr2139/sites/authentication/activeusersession-en.html Which seems to be/will be used through a CDTS and leverage some icon for the session management. Todo:
cc @GormFrank |
We'll review it this week with the whole group at DTO. |
Good morning friends. Sorry if I'm not doing this correctly. We are learning how to work together on different platforms. At DTO we reviewed the request and we have some questions we put in a google doc we are sending ... It's a draft but I wanted to share it fast instead of waiting for it to be perfect! We can iterate later... @duboisp @GormFrank @delisma https://docs.google.com/document/d/1C0Ma7aasJ6iKl253nIbGuyO2J1ZOV4wl1az9_Vl15p8/edit?usp=sharing |
I would like to mention this change request are coming from the wet-boew community where PP only assisted @crochefort during our office hours to submit this contribution. Thanks for your input @catalinaperezn For record keeping, I am re-posting the content of your shared google docs here. I would like to suggest, if possible for you and for your team, to keep the conversation here about this change request which can be made by making new comments here or in the related github issue #2138. Note: I am going to re-post here any progress and any new comments made in the shared google doc when I am made aware of any. Request for more information on pull request #2139 - Sign out and Username buttonsContextWe need more information to better understand this request. Please explain the context:
Alignment/ConsistencyThis is a major pattern for the GC user experience. To retain user trust, please explain:
Initial reactions
Demande d’information supplémentaire pour la requête de fusionnement #2139 - Boutons de déconnection et d’usagerContexteNous aurions besoin de plus d'informations pour mieux comprendre cette demande. Veuillez expliquer le contexte plus en détails:
Alignement/ConsistanceCe modèle est très important pour l'expérience utilisateur au sein du gouvernement Canadien. Pour conserver la confiance de l’usager, veuillez expliquer:
Premières réactions
|
Will work on a way to present this demo pattern as a community variant and to find a way to illustrate that there is no official guidance approved that support this variant. |
Tomorrow at the office hours, PP and DTO would discuss on how we can merge this PR without creating false perception of "Official pattern" vs "Community pattern" vs "Trusted pattern" when presenting those working example. |
@Garneauma lorsque tu auras la chance, est ce que tu pourrais mettre à jour le démo temporaire? merci. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few spelling mistakes
Pre-approved once the change is completed and a second review completed. |
e926369
to
53a61fe
Compare
53a61fe
to
296bf7d
Compare
296bf7d
to
7550282
Compare
I updated the example and GCWeb site config to be able to include comments/concern and to advise, when needed, that the pattern is a community contribution.
That depend, it is not a step process but it depend more on the enterprise readiness of the contribution, its code quality, the completeness of the contribution, our capacity to maintain the contribution as a stable product according to our versioning public API, the impact this could have on published guidance and I might miss other factor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solid first iteration of the Community stable alert box.
* Update index.json-ld * Update authentication.html * Create signedoffuser-en.html * Create signedoffuser-fr.html * Authentification - Active session pattern adjustment * Authentification - Community disclaimer for the active session example Patch - Authentication - Fix hovering contrast colour when containing a primary styled anchor --------- Co-authored-by: Pierre Dubois <pierre.dubois@servicecanada.gc.ca> Co-authored-by: Pierre Dubois <duboisp2@gmail.com>
PR pour cette issue : fix #2138
La différence es au niveau que c'Est pas des mais <a href avec la classe btn-default.
Il vas falloir corrigé la couleur pour possiblement les autres sortes de bouton