Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWG - PHP variant - site title does not receive focus #11

Closed
PCH-EdC opened this issue Sep 24, 2012 · 5 comments
Closed

AWG - PHP variant - site title does not receive focus #11

PCH-EdC opened this issue Sep 24, 2012 · 5 comments
Labels

Comments

@PCH-EdC
Copy link
Member

PCH-EdC commented Sep 24, 2012

Just to note that the PHP examples, have not been updated with the fix, so that in IE8 when you tab from the language selection link to the site title, the focus is not display when it is on the site title. Tabbing brings the focus to the search field where it is once again displayed. This happens in all the PHP examples, and it has been solved before, just not applied to these examples.

@wet-boew/access-working-group

upsonp added a commit that referenced this issue May 6, 2013
@upsonp
Copy link
Member

upsonp commented May 8, 2013

@PCH-EdC I don't have a version of IE 8 for testing, but I believe this has been corrected in the latest master PHP Variant. Can you confirm on the test site I've set up?

http://www2.mar.dfo-mpo.gc.ca:8080/wet-boew/demos-php/
User name: WEBSITEREVIEW
Password: T-9)N2z

@pjackson28
Copy link
Member

@upsonp If you are looking to do IE8 testing, you can use Sauce Labs (http://saucelabs.com). They have free accounts for open source.

@PCH-EdC
Copy link
Member Author

PCH-EdC commented May 13, 2013

I can confirm that the site title receives focus in all the English
examples (I did not test the French ones) and the underlining of the title
is a nice added bonus.

I did notice the following which is unrelated:
GC Web Usability Theme - Content page Secondary menu 2 - page shifted to
the left (no left margin) and search edit box and button hide part of the
GoC Wordmark.

WET Theme - No search or language selection link - does not have the
hidden links (eg skip to). Likewise for WET Theme - Content Page - No
Site Menu or Breadcrumb Trail. Since it happens twice, I do not know if
this is intentional or not, but I thought I would mention as I don't think
that it is.

@upsonp
Copy link
Member

upsonp commented May 14, 2013

@PCH-EdC Thanks for the notice. My work machine was in the shop for a couple of days after the windows 7 roll out so I only had my Linux box at home for testing. I'm back up and running now. I checked the Secondary menu 2 page in IE9, and it's completely broken. I'll go back and have a look to see what the issue is. I'm betting it's the same issue with the other pages.

@upsonp
Copy link
Member

upsonp commented May 16, 2013

@PCH-EdC I thought I had commented here yesterday afternoon. I used the Sauce Labs site @pjackson28 recommeneded to test the latest demo pages @nschonni and I deployed to an Azure site (http://wet-boew-php.azurewebsites.net/demos-php/index.php).

It seems like the issues you out lined are fixed. There was a leftover debug statement in the Secondary Menu 2 demo that caused bad behavior in IE, after it was removed the page worked correctly. I tested the Skip Navigation links and they seem to be ok as well.

I'm going to close this issue for now, but if you notice anything else feel free to reopen it.

@upsonp upsonp closed this as completed May 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants