Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Bower to npm" #8253

Merged
merged 1 commit into from
Feb 22, 2018
Merged

Conversation

nschonni
Copy link
Member

Reverts the Revert in #8228

@duboisp
Copy link
Member

duboisp commented Jan 16, 2018

@nschonni what kind of update we need to apply for the theme build script?

@nschonni
Copy link
Member Author

Not sure exactly, but I think mainly it comes from how the demos were using the jQuery version from the Bower file to generate the CDN links.

@LaurentGoderre
Copy link
Member

It's a bit of a big change....

@duboisp
Copy link
Member

duboisp commented Jan 17, 2018

Can, one of you, provide instructions on how we can apply that "big change" on every theme?

@LaurentGoderre
Copy link
Member

I'm working on it

@duboisp
Copy link
Member

duboisp commented Feb 22, 2018

As discussed at the technical review meeting,

This PR are going to be merge and then new PR are going to be submitted to fix the build of GCweb, Intranet, GCWU and Base theme.

@duboisp duboisp merged commit 00e8655 into master Feb 22, 2018
@LaurentGoderre LaurentGoderre deleted the revert-8228-revert-8147-bower-to-npm branch February 22, 2018 22:47
@LaurentGoderre
Copy link
Member

Note that this broke the release script. The team won't be able to use the script for next versions unless the script is fixed.

@duboisp
Copy link
Member

duboisp commented Feb 28, 2018

@nschonni or @LaurentGoderre when do you thing the GCWeb build would be fixed. I have a some update that I would need to apply to GCweb template next week and I need the GCWeb to be working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants