fix: Button.Redirect #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
tmm
commented
Mar 1, 2024
src/components/Button.tsx
Outdated
Comment on lines
99
to
102
| location && ( | ||
| <meta property={`fc:frame:button:${index}:target`} content={location} /> | ||
| target && ( | ||
| <meta property={`fc:frame:button:${index}:target`} content={target} /> |
There was a problem hiding this comment.
target is where to post the action to get the location
tmm
commented
Mar 1, 2024
Comment on lines
+254
to
+259
| if (context.status === 'redirect' && context.buttonIndex) { | ||
| const buttonValue = buttonValues[context.buttonIndex - 1] | ||
| const location = buttonValue?.replace(/^_r:/, '') | ||
| if (!location) throw new Error('location required to redirect') | ||
| return c.redirect(location, 302) | ||
| } |
There was a problem hiding this comment.
Needed to move this down so we have resolved buttonValues based on the context from the current action. Otherwise, redirect location is based on old context values.
tmm
commented
Mar 2, 2024
jxom
approved these changes
Mar 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Button.Redirectisn't working with dynamic content. This PR fixes that.TODO: Still need to make sure
targetworks correctly across frames.