Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update zksync testnet with Sepolia, deprecating Goerli #1560

Merged
merged 5 commits into from
Dec 18, 2023

Conversation

dutterbutter
Copy link
Contributor

@dutterbutter dutterbutter commented Dec 6, 2023

Description

This PR updates zkSync Testnet. Deprecating Goerli in favour of Sepolia.


PR-Codex overview

Focus of the PR:

This PR focuses on adding support for the zkSync Sepolia Testnet.

Detailed summary:

  • Added zkSync Sepolia Testnet.
  • Added zkSyncSepoliaTestnet to the list of supported chains.
  • Deprecated zkSyncTestnet and added a comment suggesting the use of zkSyncSepoliaTestnet.
  • Updated imports and references to use zkSyncSepoliaTestnet instead of zkSyncTestnet.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 16e8ff0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Dec 6, 2023

@dutterbutter is attempting to deploy a commit to the wagmi Team on Vercel.

A member of the Team first needs to authorize it.

@jxom
Copy link
Member

jxom commented Dec 6, 2023

Does 280 still work? Can we instead add an extra chain for zkSync Sepolia to avoid breaking changes? We can mark zkSyncTestnet with a @deprecated flag and direct the consumer to use Sepolia.

@dutterbutter
Copy link
Contributor Author

@jxom updated :)

@dutterbutter
Copy link
Contributor Author

@jxom gentle bump here :)

@jxom jxom merged commit 664778d into wevm:main Dec 18, 2023
13 of 22 checks passed
@github-actions github-actions bot mentioned this pull request Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants