feat: op stack fault proofs #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bd36515 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1994 +/- ##
==========================================
- Coverage 99.77% 97.39% -2.39%
==========================================
Files 580 580
Lines 50921 52743 +1822
Branches 2530 2325 -205
==========================================
+ Hits 50808 51369 +561
- Misses 100 1347 +1247
- Partials 13 27 +14 ☔ View full report in Codecov by Sentry. |
roninjin10
approved these changes
Mar 21, 2024
| test('default', async () => { | ||
| await reset(sepoliaClient, { |
There was a problem hiding this comment.
TIL reset this is useful
| * Strategy for extracting a dispute game. | ||
| * | ||
| * - `latest` - Returns the latest dispute game. | ||
| * - `random` - Returns a random dispute game. |
There was a problem hiding this comment.
Suggested change
| * - `random` - Returns a random dispute game. | |
| * - `random` - Returns a random dispute game. This helps prevent DDOS from someone submitting invalid games |
Not obvious to most people "why"?
| */ | ||
| limit?: number | undefined | ||
| /** | ||
| * Strategy for extracting a dispute game. |
There was a problem hiding this comment.
Suggested change
| * Strategy for extracting a dispute game. | |
| * Strategy for extracting a dispute game. | |
| * @default latest |
nit
| | ErrorType | ||
|
|
||
| /** | ||
| * Retrieves a valid dispute game on an L2 that occurred after a provided L2 block number. |
There was a problem hiding this comment.
Suggested change
| * Retrieves a valid dispute game on an L2 that occurred after a provided L2 block number. | |
| * Retrieves a valid [dispute game](https://specs.optimism.io/experimental/fault-proof/stage-one/dispute-game-interface.html) on an L2 that occurred after a provided L2 block number. |
Comment on lines
+91
to
+95
| const game = (() => { | ||
| if (strategy === 'random') | ||
| return games[Math.floor(Math.random() * games.length)] | ||
| return games[0] | ||
| })() |
There was a problem hiding this comment.
This is a big middle finger to ternaries lol
author Will Cory <willcory@Wills-MacBook-Pro.local> 1709088652 -0800 committer Will Cory <willcory@Wills-MacBook-Pro.local> 1710517178 -0700 Add portalVersion action to viem/opstack add test client for tevm matching anvil client pnpm i @tevm/server upgrade to versions of @tevm/opstack that don't have deps related bugs REVERTME temporary hack to make foundry work on my machine add the test and portal version action update based on comments add test client, rename createL1Client, and move to opstack test utils bun i @tevm/opstack add test client for tevm matching anvil client pnpm i @tevm/server upgrade to versions of @tevm/opstack that don't have deps related bugs REVERTME temporary hack to make foundry work on my machine add the test and portal version action feat: Add forwards compatability to getWithdrawalStatus first version of things feat: Update waitForNextL2Output fix broken lint update getTimeToFinalize add a comment complete and squash
Merged
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on adding support for Fault Proofs on OP Stack.
Detailed summary
getGame,getGames,getTimeToNextGame,waitForNextGame