Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: EIP-3074 signAuthMessage + utils #2155

Merged
merged 4 commits into from
Apr 19, 2024
Merged

feat: EIP-3074 signAuthMessage + utils #2155

merged 4 commits into from
Apr 19, 2024

Conversation

jxom
Copy link
Member

@jxom jxom commented Apr 19, 2024

PR-Codex overview

This PR introduces EIP-3074 utilities and updates file paths for consistency.

Detailed summary

  • Added EIP-3074 utilities: signAuthMessage, recoverAuthMessageAddress, verifyAuthMessage
  • Updated file paths to /experimental/eip5792/
  • Modified functions for EIP-3074 compatibility

The following files were skipped due to too many changes: src/experimental/eip3074/utils/toAuthMessage.test.ts, src/accounts/privateKeyToAccount.test.ts, src/experimental/eip3074/utils/signAuthMessage.ts, src/experimental/eip3074/utils/toAuthMessage.ts, src/experimental/eip3074/decorators/eip3074.test.ts, src/experimental/eip3074/utils/verifyAuthMessage.ts, src/experimental/actions/showCallsStatus.ts, src/experimental/actions/sendCalls.test.ts, src/experimental/eip3074/actions/signAuthMessage.test.ts, src/accounts/types.ts, src/experimental/actions/getCallsStatus.test.ts, src/experimental/eip3074/decorators/eip3074.ts, src/experimental/actions/writeContracts.test.ts, src/experimental/actions/writeContracts.ts, src/experimental/index.ts, src/experimental/actions/getCallsStatus.ts, src/experimental/actions/getCapabilities.ts, src/experimental/decorators/eip5792.ts, src/experimental/actions/sendCalls.ts, site/pages/experimental/eip3074/recoverAuthMessageAddress.mdx, src/experimental/eip3074/actions/signAuthMessage.ts, site/pages/experimental/eip3074/verifyAuthMessage.mdx, site/pages/experimental/eip3074/signAuthMessage.mdx, src/actions/wallet/prepareTransactionRequest.test.ts

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Apr 19, 2024

🦋 Changeset detected

Latest commit: b9070fd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
viem ✅ Ready (Inspect) Visit Preview Apr 19, 2024 2:49am

Copy link
Contributor

github-actions bot commented Apr 19, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
viem (esm) 67.08 KB (0%) 1.4 s (0%) 993 ms (-6.75% 🔽) 2.4 s
viem (cjs) 87.04 KB (0%) 1.8 s (0%) 1.2 s (+15.54% 🔺) 2.9 s
viem (minimal surface - tree-shaking) 3.77 KB (0%) 76 ms (0%) 24 ms (+214.04% 🔺) 99 ms
viem/accounts 91.87 KB (0%) 1.9 s (0%) 384 ms (-26.46% 🔽) 2.3 s
viem/accounts (tree-shaking) 21.48 KB (0%) 430 ms (0%) 200 ms (+201.84% 🔺) 630 ms
viem/actions 46.72 KB (0%) 935 ms (0%) 206 ms (+37.07% 🔺) 1.2 s
viem/actions (tree-shaking) 340 B (0%) 10 ms (0%) 4 ms (-79.49% 🔽) 14 ms
viem/chains 31.67 KB (0%) 634 ms (0%) 118 ms (-71.85% 🔽) 752 ms
viem/chains (tree-shaking) 367 B (0%) 10 ms (0%) 78 ms (+1323.39% 🔺) 88 ms
viem/chains/utils 1.16 KB (0%) 24 ms (0%) 5 ms (-7.78% 🔽) 28 ms
viem/ens 46.72 KB (0%) 935 ms (0%) 465 ms (+128.51% 🔺) 1.4 s
viem/ens (tree-shaking) 20.74 KB (0%) 415 ms (0%) 59 ms (-62.07% 🔽) 474 ms

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 99.23469% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 99.72%. Comparing base (581dc93) to head (5caf3b7).
Report is 17 commits behind head on main.

Files Patch % Lines
...rc/experimental/eip3074/actions/signAuthMessage.ts 97.08% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2155      +/-   ##
==========================================
- Coverage   99.74%   99.72%   -0.02%     
==========================================
  Files         614      625      +11     
  Lines       55451    55907     +456     
  Branches     2653     2652       -1     
==========================================
+ Hits        55307    55751     +444     
- Misses        131      141      +10     
- Partials       13       15       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxom jxom merged commit 803fa0d into main Apr 19, 2024
2 of 3 checks passed
@jxom jxom deleted the eip3074 branch April 19, 2024 02:45
@github-actions github-actions bot mentioned this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant