Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix batch scheduler id #2256

Merged
merged 2 commits into from
May 15, 2024

Conversation

LeTamanoir
Copy link
Contributor

@LeTamanoir LeTamanoir commented May 15, 2024

When using multiple clients initialised with http(undefined, { batch: true }) with an undefined url parameter (which internally defaults to the chain default RPC url) they would all share the same scheduler cache, sending requests to the wrongs RPCs when batched with e.g. Promise.all

cc: @0xpanoramix


PR-Codex overview

This PR fixes the batch scheduler ID in the HTTP transport module.

Detailed summary

  • Fixed batch scheduler ID in http.ts module
  • Updated the id assignment from ${url} to url_

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented May 15, 2024

🦋 Changeset detected

Latest commit: f6dcb02

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
viem Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 15, 2024

@LeTamanoir is attempting to deploy a commit to the wevm Team on Vercel.

A member of the Team first needs to authorize it.

@LeTamanoir LeTamanoir marked this pull request as draft May 15, 2024 16:49
@LeTamanoir LeTamanoir marked this pull request as ready for review May 15, 2024 16:51
@jxom jxom merged commit f9ffcf8 into wevm:main May 15, 2024
2 of 3 checks passed
@github-actions github-actions bot mentioned this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants