Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using multiple clients initialised with
http(undefined, { batch: true })
with an undefined url parameter (which internally defaults to the chain default RPC url) they would all share the same scheduler cache, sending requests to the wrongs RPCs when batched with e.g.Promise.all
cc: @0xpanoramix
PR-Codex overview
This PR fixes the batch scheduler ID in the HTTP transport module.
Detailed summary
http.ts
moduleid
assignment from${url}
tourl_