-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: siwe #2280
feat: siwe #2280
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
hell yeah |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2280 +/- ##
==========================================
- Coverage 99.70% 99.68% -0.02%
==========================================
Files 670 680 +10
Lines 57096 57684 +588
Branches 2685 2747 +62
==========================================
+ Hits 56925 57504 +579
- Misses 154 163 +9
Partials 17 17 ☔ View full report in Codecov by Sentry. |
This is the way |
src/utils/siwe/verifyMessage.ts
Outdated
address?: Address | undefined | ||
domain?: string | undefined | ||
message: string | ||
nonce?: string | undefined | ||
scheme?: string | undefined | ||
signature: Hex | ||
// TODO: `Date` or `string`? | ||
time?: Date | undefined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those fields are required in Message
type, why are they optional here?
maybe it's worth reusing Message
type properties here?
size-limit report 📦
|
Will this be compatible with ERC-6492? |
@mihoward21 yep |
ERC-4361: Sign-In with Ethereum
PR-Codex overview
This PR updates the SIWE module with new functions, error types, and utilities related to EIP-4361.
Detailed summary
generateSiweNonce
function for EIP-4361 noncesverifySiweMessage
generateSiweNonce