Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct project typos #4102

Merged
merged 6 commits into from
Jul 2, 2024
Merged

fix: correct project typos #4102

merged 6 commits into from
Jul 2, 2024

Conversation

ClumsyVlad
Copy link
Contributor

After analyzing the project code, typos in explanation comments and documentation files were found and corrected.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 041a6fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jun 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wagmi ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 1, 2024 10:38pm

tmm
tmm requested changes Jun 30, 2024
View reviewed changes
site/vue/typescript.md Outdated
@@ -290,7 +290,7 @@ import { useReadContract } from '@wagmi/vue'

useReadContract({
abi: erc721Abi,
functionName: 'balanecOf',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. Please revert this change.

site/react/typescript.md Outdated
@@ -290,7 +290,7 @@ import { useReadContract } from 'wagmi'

useReadContract({
abi: erc721Abi,
functionName: 'balanecOf',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. Please revert this change.

site/core/typescript.md Outdated
@@ -231,7 +231,7 @@ import { readContract } from '@wagmi/core'
readContract(config, {
address: '0xFBA3912Ca04dd458c843e2EE08967fC04f3579c2',
abi: erc721Abi,
functionName: 'balanecOf',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. Please revert this change.

packages/core/src/actions/watchChains.ts Outdated
@@ -12,7 +12,7 @@ export type WatchChainsReturnType = () => void

/**
* @internal
* We don't expose this because as far as consumers know, you can't chainge (lol) `config.chains` at runtime.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional. Please revert this change.

@ClumsyVlad
Copy link
Contributor Author

@tmm could you explain, please, why there should be the intentioan typo in balanceOf function name?
And also, why would you like to keep intentional typo in comment in watchChains.ts? 🤔

@ClumsyVlad ClumsyVlad requested a review from tmm July 1, 2024 14:09
@tmm
Copy link
Member

tmm commented Jul 1, 2024

why there should be the intentioan typo in balanceOf function name?

This typo is intentional to showcase Wagmi's type-safety.

image

why would you like to keep intentional typo in comment in watchChains.ts?

This is a joke we'd like to keep around.

@ClumsyVlad
Copy link
Contributor Author

ClumsyVlad commented Jul 1, 2024 •
edited
Loading

This typo is intentional to showcase Wagmi's type-safety.

Reverted 🫡

This is a joke we'd like to keep around.

Reverted 🫡

@tmm tmm merged commit 4e9493a into wevm:main Jul 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmm tmm Awaiting requested review from tmm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClumsyVlad @tmm