-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Existing name highlights: Make clickable and open popover #50
Comments
Limitation Related to clicking in the endorsement page, and making a selection: See https://developer.chrome.com/extensions/contextMenus#event-onClicked The What this means is when you click in the New York Times endorsement page you're not really clicking on what looks like a button that we drew, you're clicking into a big text field, and the only thing we get back is what you have selected. So unless the chrome.contextMenus API changes in some way, it will always be a requirement that you select the "text you want to act on" on the New York times page, not you click on what looks like a button have an action happen. Low probability: |
Limitation related to right clicking and going directly to a menu: |
3) "This design has two tabs at the top. For now we are only going to implement the "Sierra Club Endorsement" tab." More on React: React's reusable components, would be easier to use than jQuery UI, but jQuery UI is small and simple, and React is very big and can get bloated. If we went fully with React we would really need to build three applications one for the overlay menu, one for the frame around the outside of the endorsement page, and one for the new top row 'W' icon menu. I think the React libraries for all three apps would only have to be downloaded once in the extension deployable package. |
4) "Note: The current "Create a We Vote endorsement" popover (that appears when you select a name and right click) can open this new popover design." |
This is almost completely done in the spin-off issues. Most of the UI in the "popover" modal has been moved to the webapp, and is opened in an iFrame in the modal. The WebApp side is in process. |
Candidate highlighted (Yellow/Gray), not signed in: Open Modal
Candidate highlighted (Green/Red), signed in: Open Modal
Candidate highlighted (Green/Red), signed in: Sierra Club Endorsement
For all candidate name highlights, open a popover when you click on the highlighted name.
If the website already had the candidate name linked to another page, override that link and always open our popover. Place that link in the bottom of our popover per the design below.
This design has two tabs at the top. For now we are only going to implement the "Sierra Club Endorsement" tab.
Note: The current "Create a We Vote endorsement" popover (that appears when you select a name and right click) can open this new popover design.
The text was updated successfully, but these errors were encountered: