If the website already had the candidate name linked to another page, override that link #55
Comments
SailingSteve
added a commit
to SailingSteve/EndorsementExtension-1
that referenced
this issue
Feb 9, 2020
More material ui look (without actually adding all of the material ui librarys) New system pop-up Off of the WeVote icon near the omnibar, To provide enabling options and some direct links to other pages. Simplified the right click pop up in the endorsement page to have only one choice. Disabled Links On the endorsement page HTML so you don't accidentally navigate away when you click it to edit endorsement. Capture the disabled link href so we can reuse it in the dialog. Simplified the text in the sign in pop up. resolves wevote/issues/55 If the website already had the candidate name linked to another page, override that link and always open our popover resolves wevote/issues/54 For all candidate name highlights, open a popover when you click on the highlighted name. resolves wevote/issues/48 Add a pop-up menu for the 'W' extension icon after a Left Click.
SailingSteve
added a commit
to SailingSteve/EndorsementExtension-1
that referenced
this issue
Feb 11, 2020
More material ui look (without actually adding all of the material ui librarys) New system pop-up Off of the WeVote icon near the omnibar, To provide enabling options and some direct links to other pages. Simplified the right click pop up in the endorsement page to have only one choice. Disabled Links On the endorsement page HTML so you don't accidentally navigate away when you click it to edit endorsement. Capture the disabled link href so we can reuse it in the dialog. Simplified the text in the sign in pop up. resolves wevote/issues/55 If the website already had the candidate name linked to another page, override that link and always open our popover resolves wevote/issues/54 For all candidate name highlights, open a popover when you click on the highlighted name. resolves wevote/issues/48 Add a pop-up menu for the 'W' extension icon after a Left Click. resolves wevote/issues/49 The icons now display in the DOM of the endorsement page.
SailingSteve
added a commit
to SailingSteve/EndorsementExtension-1
that referenced
this issue
Feb 18, 2020
More material ui look (without actually adding all of the material ui librarys) New system pop-up Off of the WeVote icon near the omnibar, To provide enabling options and some direct links to other pages. Simplified the right click pop up in the endorsement page to have only one choice. Disabled Links On the endorsement page HTML so you don't accidentally navigate away when you click it to edit endorsement. Capture the disabled link href so we can reuse it in the dialog. Simplified the text in the sign in pop up. resolves wevote/issues/55 If the website already had the candidate name linked to another page, override that link and always open our popover resolves wevote/issues/54 For all candidate name highlights, open a popover when you click on the highlighted name. resolves wevote/issues/48 Add a pop-up menu for the 'W' extension icon after a Left Click. resolves wevote/issues/49 The icons now display in the DOM of the endorsement page. February 18, 2020 Sign in is working well again, and it removes the dialogue and the inner panel. The new way of getting the voter device ID is more robust and will fit well with the plans for a new dedicated sign in page in the web app. All we need the web app to do is change the active tab to the tab we came from, and then the extension can remove the dialogue and refresh the avatar. Highlighting the current tab works perfectly, but slowly. Opening the editor works perfectly, but doesn't leave the endorsement iframe highlighted. After getting highlighting in the I-frame running again, I want to finish adding highlighting on the chosen subset of tabs and the same for editor, and this section of design will be stable.
SailingSteve
added a commit
to SailingSteve/EndorsementExtension-1
that referenced
this issue
Feb 24, 2020
More material ui look (without actually adding all of the material ui librarys) New system pop-up Off of the WeVote icon near the omnibar, To provide enabling options and some direct links to other pages. Simplified the right click pop up in the endorsement page to have only one choice. Disabled Links On the endorsement page HTML so you don't accidentally navigate away when you click it to edit endorsement. Capture the disabled link href so we can reuse it in the dialog. Simplified the text in the sign in pop up. resolves wevote/issues/55 If the website already had the candidate name linked to another page, override that link and always open our popover resolves wevote/issues/54 For all candidate name highlights, open a popover when you click on the highlighted name. resolves wevote/issues/48 Add a pop-up menu for the 'W' extension icon after a Left Click. resolves wevote/issues/49 The icons now display in the DOM of the endorsement page. February 18, 2020 Sign in is working well again, and it removes the dialogue and the inner panel. The new way of getting the voter device ID is more robust and will fit well with the plans for a new dedicated sign in page in the web app. All we need the web app to do is change the active tab to the tab we came from, and then the extension can remove the dialogue and refresh the avatar. Highlighting the current tab works perfectly, but slowly. Opening the editor works perfectly, but doesn't leave the endorsement iframe highlighted. After getting highlighting in the I-frame running again, I want to finish adding highlighting on the chosen subset of tabs and the same for editor, and this section of design will be stable. Feb 22, put Everything including junk in to git so that I can compare it easily with the life branch. EndorsementExtensionDev
SailingSteve
added a commit
to SailingSteve/EndorsementExtension-1
that referenced
this issue
Feb 28, 2020
More material ui look (without actually adding all of the material ui libraries) New system pop-up, off of the WeVote icon near the omnibar, To provide enabling options and some direct links to other pages. Simplified the right click pop up in the endorsement page to have only one choice. Disabled Links On the endorsement page HTML so you don't accidentally navigate away when you click it to edit endorsement. Capture the disabled link href so we can reuse it in the dialog. Simplified the text in the sign in pop up. resolves wevote/issues/55 If the website already had the candidate name linked to another page, override that link and always open our popover resolves wevote/issues/54 For all candidate name highlights, open a popover when you click on the highlighted name. resolves wevote/issues/48 Add a pop-up menu for the 'W' extension icon after a Left Click. resolves wevote/issues/49 The icons now display in the DOM of the endorsement page. February 18, 2020 Sign in is working well again, and it removes the dialogue and the inner panel. The newly proposed way of getting the voter device ID is more robust and will fit well with the plans for a new dedicated sign in page in the web app. All we need the web app to do is change the active tab to the tab we came from, and then the extension can remove the dialogue and refresh the avatar. Highlighting the current tab works perfectly, but slowly. There is room to improve here. February 27, 2020 You can now turn on/off highlighting on individual pages, the teacher that turns the highlighting on for all pages it's not rocket science but it's not done, and you can turn the editor on/off for individual pages. Would like to clean up local storage, I think there's things that we are storing that have no value. There's a lot of logging it actually does slow things down, that needs to be conditional on the debug booleans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Spun off from //issues/50
2) "If the website already had the candidate name linked to another page, override that link and always open our popover. Place that link in the bottom of our popover per the design below"
Response: Here is the actual markup name and the hidden URL that could be passed to the pop-up. of the highlighted name from the sierra club site. At processing time if the name was wrapped in a 'a' element, I could disable it and maybe hide the link in the mark up with the name, and build a onClick for what I put into the DOM that would select the name and the hidden URL that could be passed to the pop-up.
The text was updated successfully, but these errors were encountered: