Refactored header spacing down to one section of code in Application, plus better iPad support #1798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(appBaseClass) for web app and 12 variants of Cordova iOS and Android devices. Cleared some exceptions
DaleMcGrew
reviewed
Nov 5, 2018
(appBaseClass) for web app and 12 variants of Cordova iOS and Android devices. Cleared some exceptions Reworked appBaseClass as requested.
DaleMcGrew
reviewed
Nov 6, 2018
DaleMcGrew
reviewed
Nov 6, 2018
that I moved to cordovaUtils.appBaseClass() for web app and the 12 variants of Cordova iOS and Androiddevices. Cleared all the open css lint issues, and most of the js lint issues. In FacebookActions, in the facebookApi call to ":/me?fields=picture..." I found that sending in "GET" as a parameter was causing a nasty uncaught exception in the c++ code that was messing up the stack, which forced the (illogical) requirement that we send in class= instead of className= in ItemPositionActionBar and AddressBox to stop a c++ level app crash when clicking in a text entry field. Changed the class= to className= in both files. In a couple of files added in getDerrivedStateFromError and componentDidCatch React 16 state handlers -- they provide an error-boundary which catches otherwise uncaught errors - solved a few problems already with these!
the mobile device. Fixes recent addition to /wevote/WeVoteCordova/issues/11 Load the vip.html static page from the webapp instead of from AWS, works on my local, but the Nginx rules might need adjustment to make this work in production. Resolves wevote/WeVoteCordova/issues/83
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored header spacing down to one section of code for Application, plus better iPad support.
I moved header size calculation to cordovaUtils.appBaseClass() for web app and the 12
variants of Cordova iOS and Android devices.
Cleared all the open csslint issues, and most of the js lint issues.
In FacebookActions, in the facebookApi call to ":/me?fields=picture..."
I found that sending in "GET" as a parameter was causing a nasty uncaught
exception in the c++ code that was messing up the stack, which forced the
(illogical) requirement that we send in class= instead of className= in
ItemPositionActionBar and AddressBox to stop a c++ level app crash when
clicking in a text entry field. Changed the class= to className= in
both files. Resolves wevote/WeVoteCordova/issues/89
In a couple of files added in getDerrivedStateFromError and
componentDidCatch React 16 state handlers -- they provide an
error-boundary which catches otherwise uncaught errors - solved a few
problems already with these!
end ballot to my friends, needs to send links to the webapp, not to the mobile device. Fixes recent addition to /wevote/WeVoteCordova/issues/11
Load the vip.html static page from the webapp instead of from AWS, works on my local, but the Nginx rules might need adjustment to make this work in production. Resolves wevote/WeVoteCordova/issues/83