feat(grid): add product grid to ray product #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Morgantheplant
added
dependencies
seimithwework
changed the title
jamesdamild
reviewed
Sep 26, 2019
Morgantheplant
force-pushed
the
mcp/WEB-754
branch
from
aab2cfd
to
df8b177
Compare
|
opened in place of #233 |
seimithwework
approved these changes
Sep 26, 2019
jgbenito7
reviewed
Sep 27, 2019
| } | ||
|
|
||
| .ray-grid__cell { | ||
| background: hotpink; |
jgbenito7
reviewed
Sep 27, 2019
| device?: CellDevice; | ||
| full?: boolean; | ||
| justify?: CellJustify; | ||
| pushColumn?: 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | 10 | 11 | 12; |
There was a problem hiding this comment.
nit: you could assign this to a type and reuse
jgbenito7
reviewed
Sep 27, 2019
| import { Grid } from '../src/components/Grid'; | ||
| import '../src/components/Container/Container.scss'; | ||
|
|
||
|
|
jgbenito7
reviewed
Sep 27, 2019
| <> | ||
| <Container debug={false}> | ||
| <Grid> | ||
| <Grid.Cell span={1}>Span 1</Grid.Cell> |
There was a problem hiding this comment.
nit: you could loop these
jgbenito7
approved these changes
Sep 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.weworkers.io/browse/WEB-754
Moves the Container, Grid, and Cell over from core-components.
I also updated the jest config in ray product-react to also check .tsx, .ts, and .jsx extensions. It looks like the tests weren't running on the tsx files.
Packages added:
enzyme-to-json - for snapshots to run similar to core-components
identity-obj-proxy - for stubbing out css modules in tests
The code here was mostly untouched except for swapping out classnames package for clsx