feat(core-react): change "type" to "variant" on Button #241

i8ramin · 2019-10-14T19:24:50Z

The type attribute is a valid Button attribute (can have values submit, reset and button - https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button), so changing the current type attribute to variant

original PR: #235

packages/core-react/package.json

i8ramin requested a review from a team as a code owner October 14, 2019 19:24

i8ramin changed the title ~~Rb/button variant~~ feat(core-react): change "type" to "variant" on Button Oct 14, 2019

wuweiweiwu approved these changes Oct 14, 2019

View reviewed changes

packages/core-react/package.json Outdated Show resolved Hide resolved

i8ramin added the package: core-react label Oct 14, 2019

i8ramin mentioned this pull request Oct 14, 2019

feat(core-react): change type to kind on Button #235

Closed

i8ramin requested a review from adamraider October 14, 2019 19:45

adamraider approved these changes Oct 14, 2019

View reviewed changes

Ramin B added 4 commits November 1, 2019 10:58

feat(core-react): change type to kind on Button

4eb968e

use 'variant' instead

2d08cfd

Remove config

def514e

Change to test:watch

0731f5f

i8ramin force-pushed the rb/button-variant branch from fbada2e to 0731f5f Compare November 1, 2019 14:59

i8ramin merged commit 1d47fd4 into master Nov 1, 2019

delete-merged-branch bot deleted the rb/button-variant branch November 1, 2019 16:12

Provide feedback