Feat(ray-product):Added Radio in tsx format #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesdamild
requested review from
Morgantheplant,
jgbenito7 and
seimithwework
seimithwework
approved these changes
Oct 28, 2019
jgbenito7
reviewed
Oct 28, 2019
| import Radio from './Radio'; | ||
|
|
||
| describe('Radio', () => { | ||
| test('it renders a radio', () => { |
There was a problem hiding this comment.
you might as well use it instead of test if you're going to start the strings with "it"
There was a problem hiding this comment.
I change the work thanks
jgbenito7
reviewed
Oct 28, 2019
| expect(wrapper.find('.ray-radio.some-custom-class').length).toBe(1); | ||
| }); | ||
|
|
||
| test('it a pill style', () => { |
jgbenito7
reviewed
Oct 28, 2019
| return ( | ||
| <div className={wrapperClass}> | ||
| <input | ||
| className={pill ? 'ray-radio-pill__input' : 'ray-radio__input'} |
There was a problem hiding this comment.
should this class be ray-radio__pill-input?
There was a problem hiding this comment.
jgbenito7
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ray Component: https://ray.wework.com/components/radio/
How to run locally
$ yarn storybook
$ yarn test core-components --watch
Nutshell Details:
Semantic wrapper around Radio element: