Disabling reference-components-regex #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
force-pushed
the
feature/regex
branch
from
074f004
to
6e33326
Compare
philsturgeon
commented
Apr 2, 2018
| @@ -688,7 +688,9 @@ function checkPathItem(pathItem, path, openapi, options) { | |||
| op.should.not.have.property('produces'); | |||
| op.should.not.have.property('schemes'); | |||
| op.should.have.property('responses'); | |||
| op.responses.should.not.be.empty(); | |||
| if (!(typeof op.responses === 'object' && Object.keys(op.responses).length > 0)) { | |||
There was a problem hiding this comment.
Unrelated, but an empty responses was causing unclear errors.
philsturgeon
commented
Apr 2, 2018
| post: | ||
| summary: b | ||
| parameters: | ||
| - $ref: './parameters.yaml#/foo' |
There was a problem hiding this comment.
This should be considered valid, but supposedly is not.
philsturgeon
force-pushed
the
feature/regex
branch
2 times, most recently
from
84709e5
to
8bd2756
Compare
philsturgeon
commented
Apr 2, 2018
test/linter.test.js
Outdated
| done(); | ||
| }); | ||
|
|
||
| it('is valid with ./', done => { |
There was a problem hiding this comment.
This is coming up as true.
test/linter.test.js
Outdated
| } | ||
| }; | ||
|
|
||
| it('should error if missing ./', done => { |
There was a problem hiding this comment.
This test is failing, as missing a ./ is showing up as valid... this seems to be the opposite of the complaints.
philsturgeon
force-pushed
the
feature/regex
branch
from
29ecc8f
to
a348422
Compare
philsturgeon
changed the title
philsturgeon
force-pushed
the
feature/regex
branch
from
a348422
to
74ded8e
Compare
igor-brishkoski
approved these changes
Apr 3, 2018
lib/linter.js
Outdated
| }); | ||
| if (target) { | ||
| if (split) { | ||
| // console.log('====\ntarget', target); |
There was a problem hiding this comment.
remove commented code if not needed.
philsturgeon
force-pushed
the
feature/regex
branch
from
74ded8e
to
1fcd638
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resolver is rewriting $refs, so it turns
'./schemas/parameters.yml#/Page'into'#/paths/~1v1~1conversations/get/parameters/1'and sometimes puts that value intox-miroinstead.We'll track fixing this in #43, but for the sake of fixing things for multiple users we gotta disable this rule.
Some other random changes snuck in, please don't complain about the boyscouting.
Fixes #23