Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for URLs when protocol is missing #80

Merged
merged 1 commit into from
May 31, 2018
Merged

Fix for URLs when protocol is missing #80

merged 1 commit into from
May 31, 2018

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented May 30, 2018 •
edited
Loading

Fixes #79

@philsturgeon philsturgeon force-pushed the bug/issue-79 branch 2 times, most recently from 8f99631 to e69db19 Compare May 30, 2018 20:57
@philsturgeon philsturgeon mentioned this pull request May 30, 2018
Closed
@coveralls
Copy link

coveralls commented May 30, 2018 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 72.835% when pulling 8287d5d on bug/issue-79 into 0ccb2d1 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.835% when pulling e69db19 on bug/issue-79 into 0ccb2d1 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.835% when pulling e69db19 on bug/issue-79 into 0ccb2d1 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 72.835% when pulling e69db19 on bug/issue-79 into 0ccb2d1 on master.

@philsturgeon philsturgeon mentioned this pull request May 31, 2018
Closed
@MikeRalphson
Copy link
Contributor

LGTM. A similar fix/simplification is in s2o's mono branch.

@philsturgeon philsturgeon merged commit 521f0b1 into master May 31, 2018
@philsturgeon philsturgeon deleted the bug/issue-79 branch May 31, 2018 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeRalphson MikeRalphson Awaiting requested review from MikeRalphson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philsturgeon @coveralls @MikeRalphson