Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added basic jekyll site #88

Merged
merged 3 commits into from
Jun 14, 2018
Merged

Added basic jekyll site #88

merged 3 commits into from
Jun 14, 2018

Conversation

philsturgeon
Copy link
Contributor

@philsturgeon philsturgeon commented Jun 13, 2018

Fixes #54

Added links to a new site which explains rules a bit better:

screen shot 2018-06-13 at 2 41 30 pm

The site is super basic, some have examples, etc. This will be improved over time.

screen shot 2018-06-13 at 2 34 19 pm

@coveralls
Copy link

coveralls commented Jun 13, 2018

Coverage Status

Coverage remained the same at 72.835% when pulling 6297c90 on would-you-like-to-know-more into d5d6380 on master.

@philsturgeon
Copy link
Contributor Author

@rachelsison @iainmcgin @mryave and anyone else who was interested in #54, please could you take a look at this PR?

@dangoosby
Copy link
Contributor

@philsturgeon shouldn't you edit the ./.circleci/config.yml so jekyll can build and test? Also, add a Dockerfile (depending on deployment/hosting)?

Otherwise this is a great start to Speccy.io!! 🚀 👍

Copy link
Contributor

@dangoosby dangoosby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@philsturgeon philsturgeon merged commit 8cb6bed into master Jun 14, 2018
@philsturgeon
Copy link
Contributor Author

Great point on circle but I’ll address that in a follow up.

This is gonna be github pages so that’s nice and easy!

@philsturgeon philsturgeon deleted the would-you-like-to-know-more branch June 14, 2018 00:01
@MikeRalphson
Copy link
Contributor

Is there a link to a gh-pages preview of the site? Sorry if being dim.

@philsturgeon
Copy link
Contributor Author

philsturgeon commented Jun 14, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants